Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2825373002: PlzNavigate: remove wrong usage of GetFrameHostForNavigation (Closed)

Created:
3 years, 8 months ago by clamy
Modified:
3 years, 8 months ago
Reviewers:
nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: remove wrong usage of GetFrameHostForNavigation https://codereview.chromium.org/2750503010 introduced a call to GetFrameHostForNavigation while not meaning to create a RenderFrameHostForNavigation. This is a wrong usage of this function. This CL removes it in favor of using navigating_frame_host that was defined earlier in the function. BUG=711848 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2825373002 Cr-Commit-Position: refs/heads/master@{#465675} Committed: https://chromium.googlesource.com/chromium/src/+/00d22da8fba8b6620cb2df2fc388bb6d096674e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M content/browser/frame_host/navigation_request.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
clamy
@nasko: PTAL
3 years, 8 months ago (2017-04-19 14:33:30 UTC) #6
nasko
LGTM I do wonder if it is possible to write a test for this, just ...
3 years, 8 months ago (2017-04-19 18:10:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825373002/1
3 years, 8 months ago (2017-04-19 18:15:15 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 18:22:25 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/00d22da8fba8b6620cb2df2fc388...

Powered by Google App Engine
This is Rietveld 408576698