Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2750503010: Ensure that if appcache is disabled for a page that navigation requests don't use it. (Closed)

Created:
3 years, 9 months ago by jam
Modified:
3 years, 9 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure that if appcache is disabled for a page that navigation requests don't use it. This fixes AwSettingsTest#testAppCacheWithTwoViews with PlzNavigate. BUG=645983 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2750503010 Cr-Commit-Position: refs/heads/master@{#456779} Committed: https://chromium.googlesource.com/chromium/src/+/87bd05ec8da9f4de31622dba5cb8817249d7c85b

Patch Set 1 #

Patch Set 2 : without PlzNavigate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M content/browser/frame_host/navigation_request.cc View 4 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jam
3 years, 9 months ago (2017-03-14 18:05:41 UTC) #5
sgurun-gerrit only
lgtm
3 years, 9 months ago (2017-03-14 18:59:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750503010/20001
3 years, 9 months ago (2017-03-14 19:05:01 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 19:11:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/87bd05ec8da9f4de31622dba5cb8...

Powered by Google App Engine
This is Rietveld 408576698