Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2825363002: Revert of DCHECK for execution context being unsuspended during v8 bindings callback. (Closed)

Created:
3 years, 8 months ago by Michael Hablich
Modified:
3 years, 8 months ago
Reviewers:
haraken, altimin
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, Sami
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DCHECK for execution context being unsuspended during v8 bindings callback. (patchset #2 id:20001 of https://codereview.chromium.org/2800093002/ ) Reason for revert: Speculative revert because of BUG=711196 Original issue's description: > DCHECK for execution context being unsuspended during v8 bindings callback. > > To prevent loss of data, change silent failure when trying to run a v8 callback on a suspended execution context to a DCHECK. > > R=haraken@chromium.org > CC=skyostil@chromium.org > > BUG=702218, 702160 > > Review-Url: https://codereview.chromium.org/2800093002 > Cr-Commit-Position: refs/heads/master@{#463869} > Committed: https://chromium.googlesource.com/chromium/src/+/7e5e14e80e181ad914e09d9f607281f248ec49e6 TBR=haraken@chromium.org,altimin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=702218, 702160 Review-Url: https://codereview.chromium.org/2825363002 Cr-Commit-Position: refs/heads/master@{#465622} Committed: https://chromium.googlesource.com/chromium/src/+/a8835855fb816d7f96b3b009d52b814129a02bde

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp View 8 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Hablich
Created Revert of DCHECK for execution context being unsuspended during v8 bindings callback.
3 years, 8 months ago (2017-04-19 14:03:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825363002/1
3 years, 8 months ago (2017-04-19 14:04:30 UTC) #3
haraken
LGTM to revert
3 years, 8 months ago (2017-04-19 14:29:09 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 15:47:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a8835855fb816d7f96b3b009d52b...

Powered by Google App Engine
This is Rietveld 408576698