Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2800093002:
DCHECK for execution context being unsuspended during v8 bindings callback. (Closed)
DescriptionDCHECK for execution context being unsuspended during v8 bindings callback.
To prevent loss of data, change silent failure when trying to run a v8 callback on a suspended execution context to a DCHECK.
R=haraken@chromium.org
CC=skyostil@chromium.org
BUG=702218, 702160
Review-Url: https://codereview.chromium.org/2800093002
Cr-Original-Commit-Position: refs/heads/master@{#463869}
Committed: https://chromium.googlesource.com/chromium/src/+/7e5e14e80e181ad914e09d9f607281f248ec49e6
Review-Url: https://codereview.chromium.org/2800093002
Cr-Commit-Position: refs/heads/master@{#467459}
Committed: https://chromium.googlesource.com/chromium/src/+/89bf4588a7238e2da23c119ad363edab624e73e4
Patch Set 1 #Patch Set 2 : Rebased #
Messages
Total messages: 22 (15 generated)
The CQ bit was checked by altimin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== DCHECK for v8 bindings execution context being unsuspended BUG=702218 ========== to ========== DCHECK for v8 bindings execution context being unsuspended BUG=702218 ==========
Description was changed from ========== DCHECK for v8 bindings execution context being unsuspended BUG=702218 ========== to ========== DCHECK for execution context being unsuspended during v8 bindings callback. To prevent loss of data, change silent failure when trying to run a v8 callback on a suspended execution context to a DCHECK. R=haraken@chromium.org CC=skyostil@chromium.org BUG=702218,702160 ==========
altimin@chromium.org changed reviewers: + haraken@chromium.org
PTAL
LGTM
The CQ bit was checked by altimin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491951954143860,
"parent_rev": "8e3c185effa25c01193d44193fd661d5a88d56fc", "commit_rev":
"7e5e14e80e181ad914e09d9f607281f248ec49e6"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491951954143860,
"parent_rev": "8e3c185effa25c01193d44193fd661d5a88d56fc", "commit_rev":
"7e5e14e80e181ad914e09d9f607281f248ec49e6"}
Message was sent while issue was closed.
Description was changed from ========== DCHECK for execution context being unsuspended during v8 bindings callback. To prevent loss of data, change silent failure when trying to run a v8 callback on a suspended execution context to a DCHECK. R=haraken@chromium.org CC=skyostil@chromium.org BUG=702218,702160 ========== to ========== DCHECK for execution context being unsuspended during v8 bindings callback. To prevent loss of data, change silent failure when trying to run a v8 callback on a suspended execution context to a DCHECK. R=haraken@chromium.org CC=skyostil@chromium.org BUG=702218,702160 Review-Url: https://codereview.chromium.org/2800093002 Cr-Commit-Position: refs/heads/master@{#463869} Committed: https://chromium.googlesource.com/chromium/src/+/7e5e14e80e181ad914e09d9f6072... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/7e5e14e80e181ad914e09d9f6072...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2825363002/ by hablich@chromium.org. The reason for reverting is: Speculative revert because of BUG=711196.
Message was sent while issue was closed.
Description was changed from ========== DCHECK for execution context being unsuspended during v8 bindings callback. To prevent loss of data, change silent failure when trying to run a v8 callback on a suspended execution context to a DCHECK. R=haraken@chromium.org CC=skyostil@chromium.org BUG=702218,702160 Review-Url: https://codereview.chromium.org/2800093002 Cr-Commit-Position: refs/heads/master@{#463869} Committed: https://chromium.googlesource.com/chromium/src/+/7e5e14e80e181ad914e09d9f6072... ========== to ========== DCHECK for execution context being unsuspended during v8 bindings callback. To prevent loss of data, change silent failure when trying to run a v8 callback on a suspended execution context to a DCHECK. R=haraken@chromium.org CC=skyostil@chromium.org BUG=702218,702160 Review-Url: https://codereview.chromium.org/2800093002 Cr-Commit-Position: refs/heads/master@{#463869} Committed: https://chromium.googlesource.com/chromium/src/+/7e5e14e80e181ad914e09d9f6072... ==========
The CQ bit was checked by altimin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493228419574860,
"parent_rev": "0afec7f0abb48a397e0b8c083d4735eb5b207e13", "commit_rev":
"89bf4588a7238e2da23c119ad363edab624e73e4"}
Message was sent while issue was closed.
Description was changed from ========== DCHECK for execution context being unsuspended during v8 bindings callback. To prevent loss of data, change silent failure when trying to run a v8 callback on a suspended execution context to a DCHECK. R=haraken@chromium.org CC=skyostil@chromium.org BUG=702218,702160 Review-Url: https://codereview.chromium.org/2800093002 Cr-Commit-Position: refs/heads/master@{#463869} Committed: https://chromium.googlesource.com/chromium/src/+/7e5e14e80e181ad914e09d9f6072... ========== to ========== DCHECK for execution context being unsuspended during v8 bindings callback. To prevent loss of data, change silent failure when trying to run a v8 callback on a suspended execution context to a DCHECK. R=haraken@chromium.org CC=skyostil@chromium.org BUG=702218,702160 Review-Url: https://codereview.chromium.org/2800093002 Cr-Original-Commit-Position: refs/heads/master@{#463869} Committed: https://chromium.googlesource.com/chromium/src/+/7e5e14e80e181ad914e09d9f6072... Review-Url: https://codereview.chromium.org/2800093002 Cr-Commit-Position: refs/heads/master@{#467459} Committed: https://chromium.googlesource.com/chromium/src/+/89bf4588a7238e2da23c119ad363... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/89bf4588a7238e2da23c119ad363... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
