Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2825323002: Revert of [turbofan] Set proper representation for initial arguments length. (Closed)

Created:
3 years, 8 months ago by Camillo Bruni
Modified:
3 years, 7 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com, Toon Verwaest
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Set proper representation for initial arguments length. (patchset #1 id:1 of https://codereview.chromium.org/2810333004/ ) Reason for revert: Field representation is not preserved Original issue's description: > [turbofan] Set proper representation for initial arguments length. > > The JSArgumentsObject::length representation is initially Smi, so we can > record that on the initial map and use it to optimize the accesses in > TurboFan based on that. Similar for JSSloppyArgumentsObject::caller. > > BUG=v8:6262 > R=yangguo@chromium.org > > Review-Url: https://codereview.chromium.org/2810333004 > Cr-Commit-Position: refs/heads/master@{#44644} > Committed: https://chromium.googlesource.com/v8/v8/+/5eec7df9b319e5b7a8158d82825d61e90a7cfe33 TBR=yangguo@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:6262 Review-Url: https://codereview.chromium.org/2825323002 Cr-Commit-Position: refs/heads/master@{#44893} Committed: https://chromium.googlesource.com/v8/v8/+/6b4b0624894ed91e4dcbf708431da78cadd83da8

Patch Set 1 #

Patch Set 2 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M src/bootstrapper.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/access-builder.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/arguments.js View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Camillo Bruni
Created Revert of [turbofan] Set proper representation for initial arguments length.
3 years, 8 months ago (2017-04-19 12:11:22 UTC) #1
Benedikt Meurer
LGTM
3 years, 8 months ago (2017-04-19 12:58:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825323002/90001
3 years, 7 months ago (2017-04-26 14:05:36 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-26 14:53:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:90001) as
https://chromium.googlesource.com/v8/v8/+/6b4b0624894ed91e4dcbf708431da78cadd...

Powered by Google App Engine
This is Rietveld 408576698