Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2810333004: [turbofan] Set proper representation for initial arguments length. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Set proper representation for initial arguments length. The JSArgumentsObject::length representation is initially Smi, so we can record that on the initial map and use it to optimize the accesses in TurboFan based on that. Similar for JSSloppyArgumentsObject::caller. BUG=v8:6262 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2810333004 Cr-Commit-Position: refs/heads/master@{#44644} Committed: https://chromium.googlesource.com/v8/v8/+/5eec7df9b319e5b7a8158d82825d61e90a7cfe33

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/bootstrapper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Benedikt Meurer
3 years, 8 months ago (2017-04-13 12:35:57 UTC) #1
Yang
On 2017/04/13 12:35:57, Benedikt Meurer wrote: lgtm.
3 years, 8 months ago (2017-04-13 12:36:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810333004/1
3 years, 8 months ago (2017-04-13 13:01:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/5eec7df9b319e5b7a8158d82825d61e90a7cfe33
3 years, 8 months ago (2017-04-13 13:03:54 UTC) #11
Camillo Bruni
3 years, 8 months ago (2017-04-19 12:11:21 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2825323002/ by cbruni@chromium.org.

The reason for reverting is: Field representation is not preserved.

Powered by Google App Engine
This is Rietveld 408576698