Fix flaky testAddVisualStateCallbackAfterRendererGone

Fix flaky testAddVisualStateCallbackAfterRendererGone

BUG=708486
Review-Url: https://codereview.chromium.org/2825203002
Cr-Commit-Position: refs/heads/master@{#467360}
Committed: https://chromium.googlesource.com/chromium/src/+/dd5c8367dd3a9c73ca1c0338d613d8540d7f22c0

[michaelbai, 2017-04-18 21:47:58]

Description was changed from

==========
Fix flaky testAddVisualStateCallbackAfterRendererGone

BUG=
==========

to

==========
Fix flaky testAddVisualStateCallbackAfterRendererGone

BUG=
==========

[michaelbai, 2017-04-18 21:47:58]

michaelbai@chromium.org changed reviewers:
+ tobiasjs@chromium.org

[michaelbai, 2017-04-18 21:48:08]

PTAL

[Tobias Sargeant, 2017-04-19 12:38:10]

https://codereview.chromium.org/2825203002/diff/1/android_webview/javatests/s...
File
android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java
(right):

https://codereview.chromium.org/2825203002/diff/1/android_webview/javatests/s...
android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java:107:
public void setOnRenderProcessGoneTask(Runnable task) {
Maybe move this logic into RenderProcessGoneHelper? It seems like it could be
potentially useful to other tests.

https://codereview.chromium.org/2825203002/diff/1/android_webview/javatests/s...
android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java:174:
@CommandLineFlags
nit: I know that git cl format does this, but could you please manually reindent
these lines?

[michaelbai, 2017-04-21 21:35:45]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 21:36:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 22:03:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 22:03:21]

Dry run: This issue passed the CQ dry run.

[michaelbai, 2017-04-21 22:20:06]

PTAL

https://codereview.chromium.org/2825203002/diff/1/android_webview/javatests/s...
File
android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java
(right):

https://codereview.chromium.org/2825203002/diff/1/android_webview/javatests/s...
android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java:107:
public void setOnRenderProcessGoneTask(Runnable task) {
On 2017/04/19 12:38:10, Tobias Sargeant wrote:
> Maybe move this logic into RenderProcessGoneHelper? It seems like it could be
> potentially useful to other tests.

Done.

https://codereview.chromium.org/2825203002/diff/1/android_webview/javatests/s...
android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java:174:
@CommandLineFlags
On 2017/04/19 12:38:10, Tobias Sargeant wrote:
> nit: I know that git cl format does this, but could you please manually
reindent
> these lines?

Done.

[Tobias Sargeant, 2017-04-26 12:01:44]

LGTM.

[Tobias Sargeant, 2017-04-26 12:04:42]

On 2017/04/26 12:01:44, Tobias Sargeant wrote:
> LGTM.

Oh. please set BUG=708486

[michaelbai, 2017-04-26 16:27:34]

Description was changed from

==========
Fix flaky testAddVisualStateCallbackAfterRendererGone

BUG=
==========

to

==========
Fix flaky testAddVisualStateCallbackAfterRendererGone

BUG=708486
==========

[michaelbai, 2017-04-26 16:28:25]

The CQ bit was checked by michaelbai@chromium.org

[commit-bot: I haz the power, 2017-04-26 16:29:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 17:22:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493224105997760,
"parent_rev": "fd927edcf1208e1ddd26faed7dfdcba6daca133c", "commit_rev":
"dd5c8367dd3a9c73ca1c0338d613d8540d7f22c0"}

[commit-bot: I haz the power, 2017-04-26 17:22:15]

Description was changed from

==========
Fix flaky testAddVisualStateCallbackAfterRendererGone

BUG=708486
==========

to

==========
Fix flaky testAddVisualStateCallbackAfterRendererGone

BUG=708486

Review-Url: https://codereview.chromium.org/2825203002
Cr-Commit-Position: refs/heads/master@{#467360}
Committed:
https://chromium.googlesource.com/chromium/src/+/dd5c8367dd3a9c73ca1c0338d613...
==========

[commit-bot: I haz the power, 2017-04-26 17:22:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dd5c8367dd3a9c73ca1c0338d613...