Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2825203002: Fix flaky testAddVisualStateCallbackAfterRendererGone (Closed)

Created:
3 years, 8 months ago by michaelbai
Modified:
3 years, 8 months ago
Reviewers:
Tobias Sargeant
CC:
chromium-reviews, kalyank, sadrul, android-webview-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky testAddVisualStateCallbackAfterRendererGone BUG=708486 Review-Url: https://codereview.chromium.org/2825203002 Cr-Commit-Position: refs/heads/master@{#467360} Committed: https://chromium.googlesource.com/chromium/src/+/dd5c8367dd3a9c73ca1c0338d613d8540d7f22c0

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/RenderProcessGoneHelper.java View 1 3 chunks +7 lines, -0 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java View 1 2 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
michaelbai
PTAL
3 years, 8 months ago (2017-04-18 21:48:08 UTC) #3
Tobias Sargeant
https://codereview.chromium.org/2825203002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java File android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java (right): https://codereview.chromium.org/2825203002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java#newcode107 android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java:107: public void setOnRenderProcessGoneTask(Runnable task) { Maybe move this logic ...
3 years, 8 months ago (2017-04-19 12:38:10 UTC) #4
michaelbai
PTAL https://codereview.chromium.org/2825203002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java File android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java (right): https://codereview.chromium.org/2825203002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java#newcode107 android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java:107: public void setOnRenderProcessGoneTask(Runnable task) { On 2017/04/19 12:38:10, ...
3 years, 8 months ago (2017-04-21 22:20:06 UTC) #9
Tobias Sargeant
LGTM.
3 years, 8 months ago (2017-04-26 12:01:44 UTC) #10
Tobias Sargeant
On 2017/04/26 12:01:44, Tobias Sargeant wrote: > LGTM. Oh. please set BUG=708486
3 years, 8 months ago (2017-04-26 12:04:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825203002/20001
3 years, 8 months ago (2017-04-26 16:29:02 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 17:22:16 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dd5c8367dd3a9c73ca1c0338d613...

Powered by Google App Engine
This is Rietveld 408576698