Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1952)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/RenderProcessGoneHelper.java

Issue 2825203002: Fix flaky testAddVisualStateCallbackAfterRendererGone (Closed)
Patch Set: address comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/RenderProcessGoneHelper.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/RenderProcessGoneHelper.java b/android_webview/javatests/src/org/chromium/android_webview/test/RenderProcessGoneHelper.java
index d6940efb15356707fd80a9997b42b7c0dea9e7d7..b32d48e1507be73414740f68ec2d609f77d3a654 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/RenderProcessGoneHelper.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/RenderProcessGoneHelper.java
@@ -19,6 +19,7 @@ public class RenderProcessGoneHelper implements RenderProcessGoneObserver {
private int mState;
private CallbackHelper mCallbackHelper;
+ private Runnable mOnRenderProcessGoneTask;
public RenderProcessGoneHelper() {
mCallbackHelper = new CallbackHelper();
@@ -48,6 +49,8 @@ public class RenderProcessGoneHelper implements RenderProcessGoneObserver {
@Override
public void onRenderProcessGone() {
+ if (mOnRenderProcessGoneTask != null) mOnRenderProcessGoneTask.run();
+
mState = RENDER_PROCESS_GONE_NOTIFIED_TO_AW_CONTENTS;
mCallbackHelper.notifyCalled();
}
@@ -63,4 +66,8 @@ public class RenderProcessGoneHelper implements RenderProcessGoneObserver {
mState = AW_CONTENTS_DESTROYED;
mCallbackHelper.notifyCalled();
}
+
+ public void setOnRenderProcessGoneTask(Runnable task) {
+ mOnRenderProcessGoneTask = task;
+ }
}
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698