Plumb CanvasColorParams to canvas image classes

Plumb CanvasColorParams to canvas image classes

Send the CanvasColorParams structure instead of the individual
parameters.

Propagate CanvasColorParams to DrawingBuffer, and use the specified
color space instead of defaulting to SRGB.

BUG=711107
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2825183002
Cr-Commit-Position: refs/heads/master@{#465515}
Committed: https://chromium.googlesource.com/chromium/src/+/914a3662e9947933953bf8e3935797621f48ec93

[ccameron, 2017-04-18 21:21:09]

Description was changed from

==========
Plumb CanvasColorParams to canvas image classes

Send the CanvasColorParams structure instead of the individual
parameters.

Propagate CanvasColorParams to DrawingBuffer, and use the specified
color space instead of defaulting to SRGB.

BUG=711107
==========

to

==========
Plumb CanvasColorParams to canvas image classes

Send the CanvasColorParams structure instead of the individual
parameters.

Propagate CanvasColorParams to DrawingBuffer, and use the specified
color space instead of defaulting to SRGB.

BUG=711107
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2017-04-18 21:21:10]

Description was changed from

==========
Plumb CanvasColorParams to canvas image classes

Send the CanvasColorParams structure instead of the individual
parameters.

Propagate CanvasColorParams to DrawingBuffer, and use the specified
color space instead of defaulting to SRGB.

BUG=711107
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Plumb CanvasColorParams to canvas image classes

Send the CanvasColorParams structure instead of the individual
parameters.

Propagate CanvasColorParams to DrawingBuffer, and use the specified
color space instead of defaulting to SRGB.

BUG=711107
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2017-04-18 21:23:50]

ccameron@chromium.org changed reviewers:
+ zakerinasab@chromium.org

[ccameron, 2017-04-18 21:23:51]

ptal -- this is mostly just changing arguments around.

https://codereview.chromium.org/2825183002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/ImageBitmap.cpp (right):

https://codereview.chromium.org/2825183002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/ImageBitmap.cpp:899: // TODO(ccameron):
Retrieve full CanvasColorParams from ImageData.
I suspect we should make some changes to ImageData as well, but those changes
were more subtle, so I left them out of this (mostly copy-paste) patch.

[zakerinasab, 2017-04-18 21:46:58]

https://codereview.chromium.org/2825183002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/ImageBitmap.cpp (right):

https://codereview.chromium.org/2825183002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/ImageBitmap.cpp:904: CanvasPixelFormat
canvas_pixel_format = kRGBA8CanvasPixelFormat;
I think we need to set the canvas pixel format for non-srgb color spaces:

if (color_settings.storageFormat() != kUint8ClampedArrayStorageFormatName)
  canvas_pixel_format = kF16CanvasPixelFormat;

[ccameron, 2017-04-18 22:10:45]

Thanks -- updated.

https://codereview.chromium.org/2825183002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/ImageBitmap.cpp (right):

https://codereview.chromium.org/2825183002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/ImageBitmap.cpp:904: CanvasPixelFormat
canvas_pixel_format = kRGBA8CanvasPixelFormat;
On 2017/04/18 21:46:58, zakerinasab wrote:
> I think we need to set the canvas pixel format for non-srgb color spaces:
> 
> if (color_settings.storageFormat() != kUint8ClampedArrayStorageFormatName)
>   canvas_pixel_format = kF16CanvasPixelFormat;

Good point -- done.

[ccameron, 2017-04-18 22:25:38]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 22:26:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-04-18 22:48:51]

ccameron@chromium.org changed reviewers:
+ pdr@chromium.org

[ccameron, 2017-04-18 22:48:51]

Adding pdr@ as OWNER

[pdr., 2017-04-18 22:56:57]

On 2017/04/18 at 22:48:51, ccameron wrote:
> Adding pdr@ as OWNER

The slimming paint v2 failures seem real.

[commit-bot: I haz the power, 2017-04-18 23:02:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 23:02:58]

Dry run: Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[ccameron, 2017-04-18 23:10:35]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[ccameron, 2017-04-18 23:10:51]

Oop, needed to keep the ImageBitmap changes behind a flag. Updated.

[commit-bot: I haz the power, 2017-04-18 23:11:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2017-04-18 23:17:53]

On 2017/04/18 at 23:10:51, ccameron wrote:
> Oop, needed to keep the ImageBitmap changes behind a flag. Updated.

LGTM

[commit-bot: I haz the power, 2017-04-18 23:47:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 23:47:54]

Dry run: Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[ccameron, 2017-04-19 01:42:33]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 01:42:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-04-19 02:28:13]

The CQ bit was unchecked by ccameron@chromium.org

[ccameron, 2017-04-19 02:28:18]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-04-19 02:28:18]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2825183002/#ps60001
(title: "Require both runtime flags")

[commit-bot: I haz the power, 2017-04-19 02:28:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-04-19 02:33:59]

ccameron@chromium.org changed reviewers:
+ esprehn@chromium.org

[ccameron, 2017-04-19 02:33:59]

Adding esprehn@ for third_party/WebKit/Source/modules

[commit-bot: I haz the power, 2017-04-19 02:37:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 02:37:36]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[haraken, 2017-04-19 05:53:24]

On 2017/04/19 02:37:36, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

modules/ LGTM

[ccameron, 2017-04-19 06:17:53]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-04-19 06:18:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 07:10:32]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492582673903650,
"parent_rev": "e5fad2002f2a4b5a47b2ad900509176dbfb03dbb", "commit_rev":
"914a3662e9947933953bf8e3935797621f48ec93"}

[commit-bot: I haz the power, 2017-04-19 07:10:43]

Description was changed from

==========
Plumb CanvasColorParams to canvas image classes

Send the CanvasColorParams structure instead of the individual
parameters.

Propagate CanvasColorParams to DrawingBuffer, and use the specified
color space instead of defaulting to SRGB.

BUG=711107
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Plumb CanvasColorParams to canvas image classes

Send the CanvasColorParams structure instead of the individual
parameters.

Propagate CanvasColorParams to DrawingBuffer, and use the specified
color space instead of defaulting to SRGB.

BUG=711107
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2825183002
Cr-Commit-Position: refs/heads/master@{#465515}
Committed:
https://chromium.googlesource.com/chromium/src/+/914a3662e9947933953bf8e39357...
==========

[commit-bot: I haz the power, 2017-04-19 07:10:44]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/914a3662e9947933953bf8e39357...