Plumb CanvasColorParams to canvas image classes

third_party/WebKit/Source/core/frame/ImageBitmap.cpp

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/frame/ImageBitmap.h"
 
 #include <memory>
 #include "core/html/HTMLCanvasElement.h"
 #include "core/html/HTMLVideoElement.h"
 #include "core/html/ImageData.h"
@@ skipping 878 matching lines @@
           data->GetSkColorSpace()));
     } else {
       image_ = StaticBitmapImage::Create(sk_image);
     }
     if (!image_)
       return;
     image_->SetPremultiplied(parsed_options.premultiply_alpha);
     return;
   }
 
-  std::unique_ptr<ImageBuffer> buffer =
-      ImageBuffer::Create(parsed_options.crop_rect.Size(), kNonOpaque,
-                          kDoNotInitializeImagePixels, data->GetSkColorSpace());
+  // TODO(ccameron): Retrieve full CanvasColorParams from ImageData.

[ccameron, 2017/04/18 21:23:50]

I suspect we should make some changes to ImageData as well, but those changes
were more subtle, so I left them out of this (mostly copy-paste) patch.

+  ImageDataColorSettings color_settings;
+  data->getColorSettings(color_settings);
+  CanvasColorSpace canvas_color_space =
+      ImageData::GetCanvasColorSpace(color_settings.colorSpace());
+  CanvasPixelFormat canvas_pixel_format = kRGBA8CanvasPixelFormat;

[zakerinasab, 2017/04/18 21:46:58]

I think we need to set the canvas pixel format for non-srgb color spaces:

if (color_settings.storageFormat() != kUint8ClampedArrayStorageFormatName)
  canvas_pixel_format = kF16CanvasPixelFormat;

[ccameron, 2017/04/18 22:10:45]

Good point -- done.

+  std::unique_ptr<ImageBuffer> buffer = ImageBuffer::Create(
+      parsed_options.crop_rect.Size(), kNonOpaque, kDoNotInitializeImagePixels,
+      CanvasColorParams(canvas_color_space, canvas_pixel_format));
   if (!buffer)
     return;
 
   if (src_rect.IsEmpty()) {
     image_ = StaticBitmapImage::Create(buffer->NewSkImageSnapshot(
         kPreferNoAcceleration, kSnapshotReasonUnknown));
     return;
   }
 
   IntPoint dst_point = IntPoint(std::min(0, -parsed_options.crop_rect.X()),
@@ skipping 226 matching lines @@
 void ImageBitmap::AdjustDrawRects(FloatRect* src_rect,
                                   FloatRect* dst_rect) const {}
 
 FloatSize ImageBitmap::ElementSize(const FloatSize&) const {
   return FloatSize(width(), height());
 }
 
 DEFINE_TRACE(ImageBitmap) {}
 
 }  // namespace blink