Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2825123002: Revert of [errors] Improve NotGeneric error message (Closed)

Created:
3 years, 8 months ago by Michael Achenbach
Modified:
3 years, 8 months ago
Reviewers:
Dan Ehrenberg, Yang, jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [errors] Improve NotGeneric error message (patchset #3 id:40001 of https://codereview.chromium.org/2814043006/ ) Reason for revert: Please schedule rebasing layout test first: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/15036 https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [errors] Improve NotGeneric error message > > This changes the message from > > "method_name is not generic" > > to > > "method_name requires that 'this' be a primitive_name object" > > BUG=v8:6206 > > Review-Url: https://codereview.chromium.org/2814043006 > Cr-Commit-Position: refs/heads/master@{#44683} > Committed: https://chromium.googlesource.com/v8/v8/+/21b104e3b83569b52539ecaa83e68a3646065101 TBR=littledan@chromium.org,yangguo@chromium.org,jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6206 Review-Url: https://codereview.chromium.org/2825123002 Cr-Commit-Position: refs/heads/master@{#44701} Committed: https://chromium.googlesource.com/v8/v8/+/597102335389540fa4b51c1ebc20dd4e55a88585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -60 lines) Patch
M src/builtins/builtins-function.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/builtins/builtins-number.cc View 5 chunks +5 lines, -10 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +3 lines, -20 lines 0 comments Download
M src/messages.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M test/mjsunit/messages.js View 1 chunk +27 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [errors] Improve NotGeneric error message
3 years, 8 months ago (2017-04-18 19:19:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825123002/1
3 years, 8 months ago (2017-04-18 19:19:48 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 19:20:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/597102335389540fa4b51c1ebc20dd4e55a...

Powered by Google App Engine
This is Rietveld 408576698