[errors] Improve NotGeneric error message

[errors] Improve NotGeneric error message

This changes the message from

"method_name is not generic"

to

"method_name requires that 'this' be a primitive_name object"

BUG=v8:6206
Review-Url: https://codereview.chromium.org/2814043006
Cr-Original-Commit-Position: refs/heads/master@{#44683}
Committed: https://chromium.googlesource.com/v8/v8/+/21b104e3b83569b52539ecaa83e68a3646065101
Review-Url: https://codereview.chromium.org/2814043006
Cr-Commit-Position: refs/heads/master@{#44713}
Committed: https://chromium.googlesource.com/v8/v8/+/a031ab92aca9b3a86a20487d4141acaa577e24f1

[jgruber, 2017-04-13 08:50:31]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 08:50:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-13 08:51:28]

jgruber@chromium.org changed reviewers:
+ littledan@chromium.org, yangguo@chromium.org

[commit-bot: I haz the power, 2017-04-13 08:52:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 08:52:05]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/24438)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/20935)

[jgruber, 2017-04-13 08:54:18]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 08:54:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 09:22:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 09:22:14]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-04-13 10:28:34]

On 2017/04/13 08:51:29, jgruber wrote:

lgtm. There is a layout test failure though that you would need to rebaseline.

[Dan Ehrenberg, 2017-04-13 11:19:55]

Awesome, lgtm

Nit: Suggestion about the message contents: remove the word 'object' as the
receiver may be a primitive (you can conceptually think about built-in functions
as being in strict mode).

[Dan Ehrenberg, 2017-04-13 11:19:59]

Awesome, lgtm

Nit: Suggestion about the message contents: remove the word 'object' as the
receiver may be a primitive (you can conceptually think about built-in functions
as being in strict mode).

[jgruber, 2017-04-18 11:55:27]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 11:55:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-18 12:03:24]

On 2017/04/13 11:19:59, Dan Ehrenberg wrote:
> Awesome, lgtm
> 
> Nit: Suggestion about the message contents: remove the word 'object' as the
> receiver may be a primitive (you can conceptually think about built-in
functions
> as being in strict mode).

Done. layout tests rebaselined here: https://codereview.chromium.org/2821233003

[jgruber, 2017-04-18 12:03:44]

The CQ bit was unchecked by jgruber@chromium.org

[jgruber, 2017-04-18 12:03:49]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-04-18 12:03:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org, yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2814043006/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2017-04-18 12:03:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 12:23:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492517029086250,
"parent_rev": "228ffc08a82e25c8b665839b543a29b93a10e5aa", "commit_rev":
"21b104e3b83569b52539ecaa83e68a3646065101"}

[commit-bot: I haz the power, 2017-04-18 12:23:34]

Description was changed from

==========
[errors] Improve NotGeneric error message

This changes the message from

"method_name is not generic"

to

"method_name requires that 'this' be a primitive_name object"

BUG=v8:6206
==========

to

==========
[errors] Improve NotGeneric error message

This changes the message from

"method_name is not generic"

to

"method_name requires that 'this' be a primitive_name object"

BUG=v8:6206

Review-Url: https://codereview.chromium.org/2814043006
Cr-Commit-Position: refs/heads/master@{#44683}
Committed:
https://chromium.googlesource.com/v8/v8/+/21b104e3b83569b52539ecaa83e68a36460...
==========

[commit-bot: I haz the power, 2017-04-18 12:23:35]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/21b104e3b83569b52539ecaa83e68a36460...

[Michael Achenbach, 2017-04-18 19:19:35]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2825123002/ by machenbach@chromium.org.

The reason for reverting is: Please schedule rebasing layout test first:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...

https://github.com/v8/v8/wiki/Blink-layout-tests.

[jgruber, 2017-04-19 08:32:05]

Description was changed from

==========
[errors] Improve NotGeneric error message

This changes the message from

"method_name is not generic"

to

"method_name requires that 'this' be a primitive_name object"

BUG=v8:6206

Review-Url: https://codereview.chromium.org/2814043006
Cr-Commit-Position: refs/heads/master@{#44683}
Committed:
https://chromium.googlesource.com/v8/v8/+/21b104e3b83569b52539ecaa83e68a36460...
==========

to

==========
[errors] Improve NotGeneric error message

This changes the message from

"method_name is not generic"

to

"method_name requires that 'this' be a primitive_name object"

BUG=v8:6206

Review-Url: https://codereview.chromium.org/2814043006
Cr-Commit-Position: refs/heads/master@{#44683}
Committed:
https://chromium.googlesource.com/v8/v8/+/21b104e3b83569b52539ecaa83e68a36460...
==========

[jgruber, 2017-04-19 08:32:31]

On 2017/04/18 19:19:35, Michael Achenbach wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/2825123002/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: Please schedule rebasing layout test first:
>
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...
> 
> https://github.com/v8/v8/wiki/Blink-layout-tests.

Done, relanding.

[jgruber, 2017-04-19 08:32:38]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2017-04-19 08:32:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 08:34:24]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492590758001110,
"parent_rev": "b89ddcf1fc657a1689fe0e88d4441bdce54837c3", "commit_rev":
"a031ab92aca9b3a86a20487d4141acaa577e24f1"}

[commit-bot: I haz the power, 2017-04-19 08:34:30]

Description was changed from

==========
[errors] Improve NotGeneric error message

This changes the message from

"method_name is not generic"

to

"method_name requires that 'this' be a primitive_name object"

BUG=v8:6206

Review-Url: https://codereview.chromium.org/2814043006
Cr-Commit-Position: refs/heads/master@{#44683}
Committed:
https://chromium.googlesource.com/v8/v8/+/21b104e3b83569b52539ecaa83e68a36460...
==========

to

==========
[errors] Improve NotGeneric error message

This changes the message from

"method_name is not generic"

to

"method_name requires that 'this' be a primitive_name object"

BUG=v8:6206

Review-Url: https://codereview.chromium.org/2814043006
Cr-Original-Commit-Position: refs/heads/master@{#44683}
Committed:
https://chromium.googlesource.com/v8/v8/+/21b104e3b83569b52539ecaa83e68a36460...
Review-Url: https://codereview.chromium.org/2814043006
Cr-Commit-Position: refs/heads/master@{#44713}
Committed:
https://chromium.googlesource.com/v8/v8/+/a031ab92aca9b3a86a20487d4141acaa577...
==========

[commit-bot: I haz the power, 2017-04-19 08:34:31]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/a031ab92aca9b3a86a20487d4141acaa577...