Add [SameObject] for Media{Element,Stream}AudioSourceNode

Add [SameObject] for Media{Element,Stream}AudioSourceNode

A recent change to the spec
(https://github.com/WebAudio/web-audio-api/pull/1201) added
[SameObject].  Implement that and add tests that the same object is
returned.

BUG=697137
TEST=
MediaElementAudioSource/mediaelementaudiosourcenode.html
MediaStreamAudioSource/mediastreamaudiosourcenode.html

Review-Url: https://codereview.chromium.org/2825113002
Cr-Commit-Position: refs/heads/master@{#466034}
Committed: https://chromium.googlesource.com/chromium/src/+/43cbda6baa983102a315cb9d7a558480344254e5

[Raymond Toy, 2017-04-18 18:54:59]

rtoy@chromium.org changed reviewers:
+ foolip@chromium.org, hongchan@chromium.org

[Raymond Toy, 2017-04-18 18:54:59]

PTAL.

[hongchan, 2017-04-19 15:41:28]

https://codereview.chromium.org/2825113002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode.html
(right):

https://codereview.chromium.org/2825113002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode.html:48:
console.log(mediaSource);
Remove all |console.log|s here.

[Raymond Toy, 2017-04-19 16:34:31]

https://codereview.chromium.org/2825113002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode.html
(right):

https://codereview.chromium.org/2825113002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode.html:48:
console.log(mediaSource);
On 2017/04/19 15:41:28, hongchan wrote:
> Remove all |console.log|s here.

Done.

[Raymond Toy, 2017-04-19 16:35:45]

rtoy@chromium.org changed reviewers:
+ tkent@chromium.org

[Raymond Toy, 2017-04-19 16:35:45]

tkent: PTAL as API Owner:  Just adding [SameObject] to the attributes, as
suggested by foolip and implemented in the spec now.

[tkent, 2017-04-19 23:56:43]

lgtm

[foolip, 2017-04-20 08:24:07]

lgtm, thanks!

For simple-to-test changes like this that correspond to spec changes, it would
be great if it could be tested in web-platform-tests. I see we're not importing
webaudio/ yet, I'll send a CL to start importing it.

[foolip, 2017-04-20 08:30:10]

On 2017/04/20 08:24:07, foolip_UTC7 wrote:
> lgtm, thanks!
> 
> For simple-to-test changes like this that correspond to spec changes, it would
> be great if it could be tested in web-platform-tests. I see we're not
importing
> webaudio/ yet, I'll send a CL to start importing it.

https://codereview.chromium.org/2833743002

[Raymond Toy, 2017-04-20 15:06:08]

On 2017/04/20 08:30:10, foolip_UTC7 wrote:
> On 2017/04/20 08:24:07, foolip_UTC7 wrote:
> > lgtm, thanks!
> > 
> > For simple-to-test changes like this that correspond to spec changes, it
would
> > be great if it could be tested in web-platform-tests. I see we're not
> importing
> > webaudio/ yet, I'll send a CL to start importing it.
> 
> https://codereview.chromium.org/2833743002

Cool.  We are working on getting our own tests in shape for upstreaming to WPT,
someday.

[Raymond Toy, 2017-04-20 15:06:16]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-04-20 15:06:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 17:13:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492700776018140,
"parent_rev": "5b23f583c5014cba0aad2e6837d64fe60e694d37", "commit_rev":
"43cbda6baa983102a315cb9d7a558480344254e5"}

[commit-bot: I haz the power, 2017-04-20 17:13:13]

Description was changed from

==========
Add [SameObject] for Media{Element,Stream}AudioSourceNode

A recent change to the spec
(https://github.com/WebAudio/web-audio-api/pull/1201) added
[SameObject].  Implement that and add tests that the same object is
returned.

BUG=692137
TEST=
MediaElementAudioSource/mediaelementaudiosourcenode.html
MediaStreamAudioSource/mediastreamaudiosourcenode.html
==========

to

==========
Add [SameObject] for Media{Element,Stream}AudioSourceNode

A recent change to the spec
(https://github.com/WebAudio/web-audio-api/pull/1201) added
[SameObject].  Implement that and add tests that the same object is
returned.

BUG=692137
TEST=
MediaElementAudioSource/mediaelementaudiosourcenode.html
MediaStreamAudioSource/mediastreamaudiosourcenode.html

Review-Url: https://codereview.chromium.org/2825113002
Cr-Commit-Position: refs/heads/master@{#466034}
Committed:
https://chromium.googlesource.com/chromium/src/+/43cbda6baa983102a315cb9d7a55...
==========

[commit-bot: I haz the power, 2017-04-20 17:13:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/43cbda6baa983102a315cb9d7a55...

[Raymond Toy, 2017-04-20 21:18:48]

Description was changed from

==========
Add [SameObject] for Media{Element,Stream}AudioSourceNode

A recent change to the spec
(https://github.com/WebAudio/web-audio-api/pull/1201) added
[SameObject].  Implement that and add tests that the same object is
returned.

BUG=692137
TEST=
MediaElementAudioSource/mediaelementaudiosourcenode.html
MediaStreamAudioSource/mediastreamaudiosourcenode.html

Review-Url: https://codereview.chromium.org/2825113002
Cr-Commit-Position: refs/heads/master@{#466034}
Committed:
https://chromium.googlesource.com/chromium/src/+/43cbda6baa983102a315cb9d7a55...
==========

to

==========
Add [SameObject] for Media{Element,Stream}AudioSourceNode

A recent change to the spec
(https://github.com/WebAudio/web-audio-api/pull/1201) added
[SameObject].  Implement that and add tests that the same object is
returned.

BUG=697137
TEST=
MediaElementAudioSource/mediaelementaudiosourcenode.html
MediaStreamAudioSource/mediastreamaudiosourcenode.html

Review-Url: https://codereview.chromium.org/2825113002
Cr-Commit-Position: refs/heads/master@{#466034}
Committed:
https://chromium.googlesource.com/chromium/src/+/43cbda6baa983102a315cb9d7a55...
==========