|
|
Chromium Code Reviews
DescriptionImport web-platform-tests/webaudio/ test suite
This will cause the tests to be imported on the next import
R=hongchan@chromium.org,rtoy@chromium.org
Review-Url: https://codereview.chromium.org/2833743002
Cr-Commit-Position: refs/heads/master@{#466088}
Committed: https://chromium.googlesource.com/chromium/src/+/6e48adeac910859218ba2800b0d0176911652a41
Patch Set 1 #
Messages
Total messages: 14 (7 generated)
The CQ bit was checked by foolip@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
On 2017/04/20 18:27:10, Raymond Toy wrote: > lgtm foolip@ Just out of curiosity, I am not sure how all this WPT business runs. 1) So this CL basically means we will download WPT tests from W3C's repository and test our implementation against them, but how often? 2) How do we fix if their test is wrong? 3) What is the plan to upstream our WebAudio test to the W3C repository?
On 2017/04/20 18:38:30, hongchan wrote: > On 2017/04/20 18:27:10, Raymond Toy wrote: > > lgtm > > foolip@ > > Just out of curiosity, I am not sure how all this WPT business runs. > > 1) So this CL basically means we will download WPT tests from W3C's repository > and test our implementation against them, but how often? > 2) How do we fix if their test is wrong? > 3) What is the plan to upstream our WebAudio test to the W3C repository? https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_plat... is the entry-point for web-platform-tests in Blink, where we try to document the main points. (There are also my BlinkOn slides at https://bit.ly/blinkon7-wpt.) To extract the answers: 1) Automatic imports are intended to run at least once every 24 hours. Expect some gaps however, there are failure modes that require manual intervention to recover from. 2) To contribute changes, simply edit the tests in a Chromium CL. web_platform_tests.md mentions some things to keep in mind. 3) There's no organized effort to upstream tests. By default it'll be up to the teams that own the feature to decide whether to prioritize upstreaming, and if so to do it. For some features it will be a lot of work. If there are things that need internal APIs to test, please let me know about that, as fixing that is a priority to make web-platform-tests an attractive default way of working.
On 2017/04/20 18:52:21, foolip_UTC7 wrote: > On 2017/04/20 18:38:30, hongchan wrote: > > On 2017/04/20 18:27:10, Raymond Toy wrote: > > > lgtm > > > > foolip@ > > > > Just out of curiosity, I am not sure how all this WPT business runs. > > > > 1) So this CL basically means we will download WPT tests from W3C's repository > > and test our implementation against them, but how often? > > 2) How do we fix if their test is wrong? > > 3) What is the plan to upstream our WebAudio test to the W3C repository? > > https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_plat... > is the entry-point for web-platform-tests in Blink, where we try to document the > main points. (There are also my BlinkOn slides at https://bit.ly/blinkon7-wpt.) > To extract the answers: > > 1) Automatic imports are intended to run at least once every 24 hours. Expect > some gaps however, there are failure modes that require manual intervention to > recover from. > > 2) To contribute changes, simply edit the tests in a Chromium CL. > web_platform_tests.md mentions some things to keep in mind. > > 3) There's no organized effort to upstream tests. By default it'll be up to the > teams that own the feature to decide whether to prioritize upstreaming, and if > so to do it. For some features it will be a lot of work. > > If there are things that need internal APIs to test, please let me know about > that, as fixing that is a priority to make web-platform-tests an attractive > default way of working. Thanks for the clarification! lgtm
The CQ bit was checked by foolip@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492714398313780, "parent_rev":
"7868a2fd251dc273fedd774f50a3b06fb8d81f9c", "commit_rev":
"6e48adeac910859218ba2800b0d0176911652a41"}
Message was sent while issue was closed.
Description was changed from ========== Import web-platform-tests/webaudio/ test suite This will cause the tests to be imported on the next import R=hongchan@chromium.org,rtoy@chromium.org ========== to ========== Import web-platform-tests/webaudio/ test suite This will cause the tests to be imported on the next import R=hongchan@chromium.org,rtoy@chromium.org Review-Url: https://codereview.chromium.org/2833743002 Cr-Commit-Position: refs/heads/master@{#466088} Committed: https://chromium.googlesource.com/chromium/src/+/6e48adeac910859218ba2800b0d0... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6e48adeac910859218ba2800b0d0... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
