Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2825083002: Revert of [Chromedriver] Re-enable java tests on Android stable and beta. (Closed)

Created:
3 years, 8 months ago by gmanikpure
Modified:
3 years, 8 months ago
Reviewers:
johnchen, stgao
CC:
chromium-reviews, samuong+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chromedriver] Re-enable java tests on Android stable and beta. (patchset #1 id:1 of https://codereview.chromium.org/2820833002/ ) Reason for revert: Tests still fails on bot across all the chrome android channels : stable,beta and HEAD. https://build.chromium.org/p/chromium.fyi/builders/Android%20ChromeDriver%20Tests%20%28dbg%29/builds/33579 Original issue's description: > [Chromedriver] Re-enable java tests on Android stable and beta. > > BUG=chromedriver:922 > TBR=stgao@chromium.org > > Review-Url: https://codereview.chromium.org/2820833002 > Cr-Commit-Position: refs/heads/master@{#464955} > Committed: https://chromium.googlesource.com/chromium/src/+/db88f21898176b391c397fff32e4c47282dd31ba TBR=johnchen@chromium.org,stgao@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromedriver:922 Review-Url: https://codereview.chromium.org/2825083002 Cr-Commit-Position: refs/heads/master@{#465671} Committed: https://chromium.googlesource.com/chromium/src/+/b6895acc9d1b196b3407cc1c813dffd0d6d78f56

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/test/chromedriver/test/test_expectations View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
gmanikpure
Created Revert of [Chromedriver] Re-enable java tests on Android stable and beta.
3 years, 8 months ago (2017-04-18 17:22:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825083002/1
3 years, 8 months ago (2017-04-18 17:22:58 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-18 17:22:59 UTC) #5
johnchen
lgtm
3 years, 8 months ago (2017-04-18 17:24:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825083002/1
3 years, 8 months ago (2017-04-18 17:25:40 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-18 17:25:44 UTC) #10
gmanikpure
Hi Shuotao, Could you please take a look? Again it needs lgtm from a full ...
3 years, 8 months ago (2017-04-19 16:38:51 UTC) #11
stgao
lgtm
3 years, 8 months ago (2017-04-19 18:11:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825083002/1
3 years, 8 months ago (2017-04-19 18:12:00 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 18:12:46 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b6895acc9d1b196b3407cc1c813d...

Powered by Google App Engine
This is Rietveld 408576698