Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2820833002:
[Chromedriver] Re-enable java tests on Android stable and beta. (Closed)
|
Created:
3 years, 8 months ago by gmanikpure Modified:
3 years, 8 months ago CC:
chromium-reviews, samuong+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[Chromedriver] Re-enable java tests on Android stable and beta.
BUG=chromedriver:922
TBR=stgao@chromium.org
Review-Url: https://codereview.chromium.org/2820833002
Cr-Commit-Position: refs/heads/master@{#464955}
Committed: https://chromium.googlesource.com/chromium/src/+/db88f21898176b391c397fff32e4c47282dd31ba
Patch Set 1 #
Messages
Total messages: 22 (11 generated)
gmanikpure@chromium.org changed reviewers: + johnchen@chromium.org
John, Fix for issue#922 has been merged to android beta and stable channels. I have verified it locally and it looks good. Therefore, re-enabling the tests. Could you please take a look? Thanks.
lgtm
The CQ bit was checked by gmanikpure@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== [Chromedriver] Re-enable java tests on Android stable and beta. BUG=chromedriver:922 ========== to ========== [Chromedriver] Re-enable java tests on Android stable and beta. BUG=chromedriver:922 ==========
gmanikpure@chromium.org changed reviewers: + stgao@chromium.org
Description was changed from ========== [Chromedriver] Re-enable java tests on Android stable and beta. BUG=chromedriver:922 ========== to ========== [Chromedriver] Re-enable java tests on Android stable and beta. BUG=chromedriver:922 TBR=stgao@chromium.org ==========
The CQ bit was checked by johnchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Hi Shuotao, John attempted TBR but unfortunately it didn't work. Could you please take a look? Thanks.
lgtm
The CQ bit was checked by gmanikpure@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492453214279470, "parent_rev":
"c2f02148125c69bdce012802d9a467d725965a93", "commit_rev":
"db88f21898176b391c397fff32e4c47282dd31ba"}
Message was sent while issue was closed.
Description was changed from ========== [Chromedriver] Re-enable java tests on Android stable and beta. BUG=chromedriver:922 TBR=stgao@chromium.org ========== to ========== [Chromedriver] Re-enable java tests on Android stable and beta. BUG=chromedriver:922 TBR=stgao@chromium.org Review-Url: https://codereview.chromium.org/2820833002 Cr-Commit-Position: refs/heads/master@{#464955} Committed: https://chromium.googlesource.com/chromium/src/+/db88f21898176b391c397fff32e4... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/db88f21898176b391c397fff32e4...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2825083002/ by gmanikpure@chromium.org. The reason for reverting is: Tests still fails on bot across all the chrome android channels : stable,beta and HEAD. https://build.chromium.org/p/chromium.fyi/builders/Android%20ChromeDriver%20T.... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
