cc: Remove AccelContentPaintDurationMS and related histos.

cc: Remove AccelContentPaintDurationMS and related histos.


BUG=153644
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270193

[danakj, 2014-05-12 15:57:53]

https://codereview.chromium.org/282493002/diff/1/cc/layers/content_layer.cc
File cc/layers/content_layer.cc (right):

https://codereview.chromium.org/282493002/diff/1/cc/layers/content_layer.cc#n...
cc/layers/content_layer.cc:44:
UMA_HISTOGRAM_CUSTOM_COUNTS("Renderer4.AccelContentPaintMegapixPerSecond",
Let's delete this one too? It's coming from the same noisy data. And we can drop
the paint_end/paint_start stuff then if it's not being used anymore.

https://codereview.chromium.org/282493002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/282493002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:21240: -<histogram
name="Renderer4.AccelContentPaintDurationMS">
Instead of deleting a histogram entirely, you should mark it as deprecated.
There should be examples of this in the file.

[sohanjg, 2014-05-13 06:03:15]

Can you please take a look.
Thanks.

[Alexei Svitkine (slow), 2014-05-13 14:49:51]

histograms lgtm

[Alexei Svitkine (slow), 2014-05-13 14:50:35]

https://codereview.chromium.org/282493002/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/282493002/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:21241: - 
<owner>wiltzius@chromium.org</owner>
Nit: Actually, can you keep the existing owner tag like you do for
Renderer4.AccelContentPaintMegapixPerSecond?

I think our tools require it to be there.

[sohanjg, 2014-05-13 14:59:57]

On 2014/05/13 14:50:35, Alexei Svitkine wrote:
>
https://codereview.chromium.org/282493002/diff/20001/tools/metrics/histograms...
> File tools/metrics/histograms/histograms.xml (left):
> 
>
https://codereview.chromium.org/282493002/diff/20001/tools/metrics/histograms...
> tools/metrics/histograms/histograms.xml:21241: - 
> <mailto:owner>wiltzius@chromium.org</owner>
> Nit: Actually, can you keep the existing owner tag like you do for
> Renderer4.AccelContentPaintMegapixPerSecond?
> 
> I think our tools require it to be there.

sorry, i missed it.
ptal. thanks.

[Alexei Svitkine (slow), 2014-05-13 15:01:25]

lgtm

[danakj, 2014-05-13 17:41:01]

LGTM

[sohanjg, 2014-05-13 17:45:42]

The CQ bit was checked by sohan.jyoti@samsung.com

[commit-bot: I haz the power, 2014-05-13 17:46:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sohan.jyoti@samsung.com/282493002/40001

[commit-bot: I haz the power, 2014-05-13 20:52:51]

Change committed as 270193

[sohanjg, 2015-11-18 09:31:45]

Description was changed from

==========
cc: Remove AccelContentPaintDurationMS and related histos.


BUG=153644

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270193
==========

to

==========
cc: Remove AccelContentPaintDurationMS and related histos.


BUG=153644

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270193
==========