Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: extensions/renderer/event_emitter.cc

Issue 2824883002: [gin] Add Arguments::GetAll() (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gin/arguments.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/event_emitter.cc
diff --git a/extensions/renderer/event_emitter.cc b/extensions/renderer/event_emitter.cc
index 79b1e8292091444356d665d6c7eb6a63fd48eb31..ccd4303cedcfcc2c42be654d8d7273d48f7936dd 100644
--- a/extensions/renderer/event_emitter.cc
+++ b/extensions/renderer/event_emitter.cc
@@ -130,11 +130,7 @@ void EventEmitter::Dispatch(gin::Arguments* arguments) {
v8::HandleScope handle_scope(arguments->isolate());
v8::Local<v8::Context> context =
arguments->isolate()->GetCurrentContext();
- std::vector<v8::Local<v8::Value>> v8_args;
- if (arguments->Length() > 0) {
- // Converting to v8::Values should never fail.
- CHECK(arguments->GetRemaining(&v8_args));
- }
+ std::vector<v8::Local<v8::Value>> v8_args = arguments->GetAll();
Devlin 2017/04/17 21:55:18 There's a few more places that use this that I'll
Fire(context, &v8_args, nullptr);
}
« no previous file with comments | « no previous file | gin/arguments.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698