Remove URLRequestJob::GetResponseCode implementations.

Remove URLRequestJob::GetResponseCode implementations.

URLRequestJob itself now has a default implementation, which gets
the response code from the headers returned by GetResponseInfo.
We eventually want to remove this method, since it's redundant,
and has weird behavior for just when it is and is not safe to
call.

BUG=688481
Review-Url: https://codereview.chromium.org/2824813002
Cr-Commit-Position: refs/heads/master@{#465292}
Committed: https://chromium.googlesource.com/chromium/src/+/e0f6ab79ba3d77e09f20175897bf0664b726fec0

[mmenke, 2017-04-17 18:33:43]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 18:34:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 18:43:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 18:44:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mmenke, 2017-04-17 18:52:52]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 18:53:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 19:03:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 19:03:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mmenke, 2017-04-17 19:08:46]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 19:09:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 19:18:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 19:18:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mmenke, 2017-04-17 19:23:23]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 19:23:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 19:34:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 19:34:20]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mmenke, 2017-04-17 19:36:01]

Patchset #4 (id:60001) has been deleted

[mmenke, 2017-04-17 19:40:59]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 19:41:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 20:02:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 20:02:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mmenke, 2017-04-17 21:30:59]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 21:31:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-04-17 21:35:01]

Patchset #5 (id:100001) has been deleted

[mmenke, 2017-04-17 21:35:10]

Patchset #4 (id:80001) has been deleted

[mmenke, 2017-04-17 21:35:21]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-04-17 22:08:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 22:08:08]

Dry run: This issue passed the CQ dry run.

[mmenke, 2017-04-17 22:11:20]

mmenke@chromium.org changed reviewers:
+ juliatuttle@chromium.org, sgurun@chromium.org

[mmenke, 2017-04-17 22:11:20]

[sgurun]:  Please review android_webview.
[juliatuttle]:  Please review domain_reliability.
[altimin]:  Please review headless.

[mmenke, 2017-04-17 22:22:16]

mmenke@chromium.org changed reviewers:
+ alexclarke@chromium.org

[mmenke, 2017-04-17 22:22:16]

[+alexclarke]:  Please review headless.

[alex clarke (OOO till 29th), 2017-04-18 07:39:09]

lgtm

[sgurun-gerrit only, 2017-04-18 14:42:15]

lgtm

[Julia Tuttle, 2017-04-18 17:53:29]

domain_reliability lgtm

[mmenke, 2017-04-18 18:05:25]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-04-18 18:05:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 18:12:15]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1492538725219040,
"parent_rev": "874291b7fb8a23a1cc97bce105bb40f60a9e3f4c", "commit_rev":
"e0f6ab79ba3d77e09f20175897bf0664b726fec0"}

[commit-bot: I haz the power, 2017-04-18 18:12:24]

Description was changed from

==========
Remove URLRequestJob::GetResponseCode implementations.

URLRequestJob itself now has a default implementation, which gets
the response code from the headers returned by GetResponseInfo.
We eventually want to remove this method, since it's redundant,
and has weird behavior for just when it is and is not safe to
call.

BUG=688481
==========

to

==========
Remove URLRequestJob::GetResponseCode implementations.

URLRequestJob itself now has a default implementation, which gets
the response code from the headers returned by GetResponseInfo.
We eventually want to remove this method, since it's redundant,
and has weird behavior for just when it is and is not safe to
call.

BUG=688481

Review-Url: https://codereview.chromium.org/2824813002
Cr-Commit-Position: refs/heads/master@{#465292}
Committed:
https://chromium.googlesource.com/chromium/src/+/e0f6ab79ba3d77e09f20175897bf...
==========

[commit-bot: I haz the power, 2017-04-18 18:12:25]

Committed patchset #3 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/e0f6ab79ba3d77e09f20175897bf...