Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2135)

Unified Diff: headless/public/util/generic_url_request_job.cc

Issue 2824813002: Remove URLRequestJob::GetResponseCode implementations. (Closed)
Patch Set: Fix more stuff Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/public/util/generic_url_request_job.cc
diff --git a/headless/public/util/generic_url_request_job.cc b/headless/public/util/generic_url_request_job.cc
index b618913e47f9bbbbf055efffd45cd8424a1c0c62..e6c5386cb672ee8639782601e082fc98622334e6 100644
--- a/headless/public/util/generic_url_request_job.cc
+++ b/headless/public/util/generic_url_request_job.cc
@@ -128,21 +128,19 @@ void GenericURLRequestJob::OnFetchStartError(net::Error error) {
void GenericURLRequestJob::OnFetchComplete(
const GURL& final_url,
- int http_response_code,
scoped_refptr<net::HttpResponseHeaders> response_headers,
const char* body,
size_t body_size) {
DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
response_time_ = base::TimeTicks::Now();
- http_response_code_ = http_response_code;
response_headers_ = response_headers;
body_ = body;
body_size_ = body_size;
DispatchHeadersComplete();
- delegate_->OnResourceLoadComplete(this, final_url, http_response_code,
- response_headers_, body_, body_size_);
+ delegate_->OnResourceLoadComplete(this, final_url, response_headers_, body_,
+ body_size_);
}
int GenericURLRequestJob::ReadRawData(net::IOBuffer* buf, int buf_size) {
@@ -159,10 +157,6 @@ int GenericURLRequestJob::ReadRawData(net::IOBuffer* buf, int buf_size) {
return bytes_to_copy;
}
-int GenericURLRequestJob::GetResponseCode() const {
- return http_response_code_;
-}
-
void GenericURLRequestJob::GetResponseInfo(net::HttpResponseInfo* info) {
info->headers = response_headers_;
}
@@ -321,7 +315,6 @@ void GenericURLRequestJob::MockResponse(
mock_response_ = std::move(mock_response);
OnFetchCompleteExtractHeaders(request_->url(),
- mock_response_->http_response_code,
mock_response_->response_data.data(),
mock_response_->response_data.size());
}
« no previous file with comments | « headless/public/util/generic_url_request_job.h ('k') | headless/public/util/generic_url_request_job_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698