Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2824803002: Fix an issue that drag and drop image always has default file name. (Closed)

Created:
3 years, 8 months ago by xingliu
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix an issue that drag and drop image always has default file name. The reason is content::DropData is passed between renderer and browser through IPC message, but we didn't declare several fields as IPC_STRUCT_TRAITS. Also noticed content::DropData.file_mime_types and did_originate_from_renderer are also not declared. This CL didn't add those in case it breaks something else. BUG=702173 Review-Url: https://codereview.chromium.org/2803473003 Cr-Commit-Position: refs/heads/master@{#461942} (cherry picked from commit 0b5c13253a5c567373cf037d336a998601105082) Review-Url: https://codereview.chromium.org/2824803002 . Cr-Commit-Position: refs/branch-heads/3029@{#735} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/1acc80de5dad9f57345eaa92b1da17212254e8cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/common/drag_traits.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
xingliu
3 years, 8 months ago (2017-04-17 18:05:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1acc80de5dad9f57345eaa92b1da17212254e8cb.

Powered by Google App Engine
This is Rietveld 408576698