Fix an issue that drag and drop image always has default file name.

Fix an issue that drag and drop image always has default file name.

The reason is content::DropData is passed between renderer and browser
through IPC message, but we didn't declare several fields as
IPC_STRUCT_TRAITS.

Also noticed content::DropData.file_mime_types and
did_originate_from_renderer are also not declared. This CL didn't add
those in case it breaks something else.


BUG=702173
Review-Url: https://codereview.chromium.org/2803473003
Cr-Commit-Position: refs/heads/master@{#461942}
Committed: https://chromium.googlesource.com/chromium/src/+/0b5c13253a5c567373cf037d336a998601105082

[xingliu, 2017-04-05 00:01:50]

xingliu@chromium.org changed reviewers:
+ alexmos@chromium.org, dtrainor@chromium.org

[xingliu, 2017-04-05 00:01:50]

Hi, PTAL, thanks, this CL fixed a drag and drop issue.

[alexmos, 2017-04-05 00:43:11]

alexmos@chromium.org changed reviewers:
+ dcheng@chromium.org

[alexmos, 2017-04-05 00:43:12]

LGTM.  Please follow up on adding the other missing fields to the traits or at
least filing a bug.  Also curious why we don't have a test that would've caught
this.

Aside, I'm wondering why this file isn't covered by ipc/SECURITY_OWNERS.  Looks
like we do that for *_param_traits*.* and *_struct_traits*.*, so I wonder if we
should rename this file to match one of those patterns.  +dcheng to verify.

[xingliu, 2017-04-05 00:56:11]

On 2017/04/05 00:43:12, alexmos wrote:
> LGTM.  Please follow up on adding the other missing fields to the traits or at
> least filing a bug.  Also curious why we don't have a test that would've
caught
> this.
> 
> Aside, I'm wondering why this file isn't covered by ipc/SECURITY_OWNERS. 
Looks
> like we do that for *_param_traits*.* and *_struct_traits*.*, so I wonder if
we
> should rename this file to match one of those patterns.  +dcheng to verify.

Thanks for the review, I file a bug for later fixes:
https://bugs.chromium.org/p/chromium/issues/detail?id=708366

[xingliu, 2017-04-05 00:56:39]

The CQ bit was checked by xingliu@chromium.org

[commit-bot: I haz the power, 2017-04-05 00:57:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 02:23:23]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491353799886510, "parent_rev":
"d3a3986fe2f2e5498807e2cfe23865a0d00240d2", "commit_rev":
"0b5c13253a5c567373cf037d336a998601105082"}

[commit-bot: I haz the power, 2017-04-05 02:24:06]

Description was changed from

==========
Fix an issue that drag and drop image always has default file name.

The reason is content::DropData is passed between renderer and browser
through IPC message, but we didn't declare several fields as
IPC_STRUCT_TRAITS.

Also noticed content::DropData.file_mime_types and
did_originate_from_renderer are also not declared. This CL didn't add
those in case it breaks something else.


BUG=702173
==========

to

==========
Fix an issue that drag and drop image always has default file name.

The reason is content::DropData is passed between renderer and browser
through IPC message, but we didn't declare several fields as
IPC_STRUCT_TRAITS.

Also noticed content::DropData.file_mime_types and
did_originate_from_renderer are also not declared. This CL didn't add
those in case it breaks something else.


BUG=702173

Review-Url: https://codereview.chromium.org/2803473003
Cr-Commit-Position: refs/heads/master@{#461942}
Committed:
https://chromium.googlesource.com/chromium/src/+/0b5c13253a5c567373cf037d336a...
==========

[commit-bot: I haz the power, 2017-04-05 02:24:07]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0b5c13253a5c567373cf037d336a...

[dcheng, 2017-04-05 02:35:00]

On 2017/04/05 02:24:07, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/0b5c13253a5c567373cf037d336a...

Doh, thanks for catching this. I tested a couple different combinations, but
missed that this wasn't plumbed through.

LGTM