📰 Make the suggestions pref strings non tranlateable

[Suggestions] Make the suggestions pref strings non tranlateable

These strings are not final, making them not translateable would
reduce APK size and translation churn.

BUG=706384
Review-Url: https://codereview.chromium.org/2824773004
Cr-Commit-Position: refs/heads/master@{#465553}
Committed: https://chromium.googlesource.com/chromium/src/+/b9725a0c5358b4900b1225efd907c6f3022f7308

[dgn, 2017-04-18 13:21:19]

dgn@chromium.org changed reviewers:
+ bauerb@chromium.org, srahim@chromium.org

[dgn, 2017-04-18 13:21:19]

PTAL. I'd like to merge it to M59 branch too.

[dgn, 2017-04-18 13:21:23]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 13:21:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 13:57:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 13:57:52]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-04-18 14:05:13]

Is that worth it? We're going to have to eat the APK size cost at some point
anyway, and I'm not sure about the translation overhead.

[dgn, 2017-04-18 14:51:38]

On 2017/04/18 14:05:13, Bernhard Bauer wrote:
> Is that worth it? We're going to have to eat the APK size cost at some point
> anyway, and I'm not sure about the translation overhead.

That was a recommendation from srahim@, forwarding you the thread. Not sure if
it applied to existing strings or just the ones we would add later, so I added
it to the most recent changes I made in case they didn't completely go through
translation yet. But maybe they already got translated so that would be a
definitive reason for it to not be worth it.

[Bernhard Bauer, 2017-04-18 14:54:59]

On 2017/04/18 14:51:38, dgn (in PST timezone) wrote:
> On 2017/04/18 14:05:13, Bernhard Bauer wrote:
> > Is that worth it? We're going to have to eat the APK size cost at some point
> > anyway, and I'm not sure about the translation overhead.
> 
> That was a recommendation from srahim@, forwarding you the thread. Not sure if
> it applied to existing strings or just the ones we would add later, so I added
> it to the most recent changes I made in case they didn't completely go through
> translation yet. But maybe they already got translated so that would be a
> definitive reason for it to not be worth it.

OK, LGTM. But pleease make sure we remove this when we prepare for launch :)

[srahim, 2017-04-18 20:32:51]

lgtm

[dgn, 2017-04-19 11:03:35]

The CQ bit was checked by dgn@chromium.org

[commit-bot: I haz the power, 2017-04-19 11:03:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 11:07:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492599815665750, "parent_rev":
"8394028f0c1d57def2917345e79b68ffa6b87803", "commit_rev":
"b9725a0c5358b4900b1225efd907c6f3022f7308"}

[commit-bot: I haz the power, 2017-04-19 11:07:21]

Description was changed from

==========
[Suggestions] Make the suggestions pref strings non tranlateable

These strings are not final, making them not translateable would
reduce APK size and translation churn.

BUG=706384
==========

to

==========
[Suggestions] Make the suggestions pref strings non tranlateable

These strings are not final, making them not translateable would
reduce APK size and translation churn.

BUG=706384

Review-Url: https://codereview.chromium.org/2824773004
Cr-Commit-Position: refs/heads/master@{#465553}
Committed:
https://chromium.googlesource.com/chromium/src/+/b9725a0c5358b4900b1225efd907...
==========

[commit-bot: I haz the power, 2017-04-19 11:07:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b9725a0c5358b4900b1225efd907...