Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2824503002: Allow WebView setCookie api to set secure cookies for http urls. (Closed)

Created:
3 years, 8 months ago by sgurun-gerrit only
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Allow WebView setCookie api to set secure cookies for http urls. Starting with Chrome M58, setting secure cookies for http urls is not allowed (strict secure cookies). However, Webview using applications used to set cookies using a Webview setCookie API and until now we discovered 3 apps doing that and failing in different ways. This change is a temporary hack to allow this API to modify HTTP urls to HTTPS when setting secure cookies. BUG=706993 Review-Url: https://codereview.chromium.org/2821623003 Cr-Commit-Position: refs/heads/master@{#464734} (cherry picked from commit 50549382727806e2ae44c45444827d02270b5d57) Review-Url: https://codereview.chromium.org/2824503002 . Cr-Commit-Position: refs/branch-heads/3029@{#715} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/159d352e7da2f956e8b29f40efc0d6cb50de0f4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java View 1 chunk +10 lines, -0 lines 0 comments Download
M android_webview/native/cookie_manager.cc View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
sgurun-gerrit only
3 years, 8 months ago (2017-04-14 17:34:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
159d352e7da2f956e8b29f40efc0d6cb50de0f4b.

Powered by Google App Engine
This is Rietveld 408576698