Allow WebView setCookie api to set secure cookies for http urls.

Allow WebView setCookie api to set secure cookies for http urls.

Starting with Chrome M58, setting secure cookies for http urls is not
allowed (strict secure cookies). However, Webview using applications
used to set cookies using a Webview setCookie API and until now
we discovered 3 apps doing that and failing in different ways. This
change is a temporary hack to allow this API to modify HTTP urls to
HTTPS when setting secure cookies.

BUG=706993
Review-Url: https://codereview.chromium.org/2821623003
Cr-Commit-Position: refs/heads/master@{#464734}
Committed: https://chromium.googlesource.com/chromium/src/+/50549382727806e2ae44c45444827d02270b5d57

[sgurun-gerrit only, 2017-04-14 04:28:03]

Description was changed from

==========
Allow WebView setCookie api to set secure cookies for http urls.

Starting with Chrome M58, setting secure cookies for http urls is not
allowed (strict secure cookies). However, Webview using applications
used to set cookies using a Webview setCookie API and until now
we discovered 3 apps doing that and failing in different ways. This
change is a temporary hack to allow this API to modify HTTP urls to
HTTPS when setting secure cookies.

BUG=706993
==========

to

==========
Allow WebView setCookie api to set secure cookies for http urls.

Starting with Chrome M58, setting secure cookies for http urls is not
allowed (strict secure cookies). However, Webview using applications
used to set cookies using a Webview setCookie API and until now
we discovered 3 apps doing that and failing in different ways. This
change is a temporary hack to allow this API to modify HTTP urls to
HTTPS when setting secure cookies.

BUG=706993
==========

[sgurun-gerrit only, 2017-04-14 04:28:03]

sgurun@chromium.org changed reviewers:
+ mkwst@chromium.org

[sgurun-gerrit only, 2017-04-14 04:28:53]

Mike, this is the issue I emailed you about. I verified that it fixes both
Walmart and Yahoo sports app. 

PTAL,

[Mike West, 2017-04-14 06:04:21]

Can you add a test for this behavior?

[sgurun-gerrit only, 2017-04-14 14:33:10]

On 2017/04/14 06:04:21, Mike West wrote:
> Can you add a test for this behavior?

added a test, ptal.

[Mike West, 2017-04-14 16:10:08]

lgtm

[sgurun-gerrit only, 2017-04-14 16:26:11]

The CQ bit was checked by sgurun@chromium.org

[commit-bot: I haz the power, 2017-04-14 16:26:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 16:47:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492187171227640,
"parent_rev": "e52823c7335665f3d677aea336df98dda1d25641", "commit_rev":
"50549382727806e2ae44c45444827d02270b5d57"}

[commit-bot: I haz the power, 2017-04-14 16:48:31]

Description was changed from

==========
Allow WebView setCookie api to set secure cookies for http urls.

Starting with Chrome M58, setting secure cookies for http urls is not
allowed (strict secure cookies). However, Webview using applications
used to set cookies using a Webview setCookie API and until now
we discovered 3 apps doing that and failing in different ways. This
change is a temporary hack to allow this API to modify HTTP urls to
HTTPS when setting secure cookies.

BUG=706993
==========

to

==========
Allow WebView setCookie api to set secure cookies for http urls.

Starting with Chrome M58, setting secure cookies for http urls is not
allowed (strict secure cookies). However, Webview using applications
used to set cookies using a Webview setCookie API and until now
we discovered 3 apps doing that and failing in different ways. This
change is a temporary hack to allow this API to modify HTTP urls to
HTTPS when setting secure cookies.

BUG=706993

Review-Url: https://codereview.chromium.org/2821623003
Cr-Commit-Position: refs/heads/master@{#464734}
Committed:
https://chromium.googlesource.com/chromium/src/+/50549382727806e2ae44c4544482...
==========

[commit-bot: I haz the power, 2017-04-14 16:48:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/50549382727806e2ae44c4544482...