Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 2824493002: Reland of [ObjC ARC] Converts ios/chrome/browser/ui/contextual_search:contextual_search to ARC. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 2 weeks ago by stkhapugin_OOO_until_May_30
Modified:
1 month, 1 week ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl -pls.ping.after.24h., noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [ObjC ARC] Converts ios/chrome/browser/ui/contextual_search:contextual_search to ARC. Notable changes: * modifies a unit test to not fail with ARC. * original CL https://codereview.chromium.org/2626073003 BUG=624363 Review-Url: https://codereview.chromium.org/2824493002 Cr-Commit-Position: refs/heads/master@{#465213} Committed: https://chromium.googlesource.com/chromium/src/+/7affbfc7f68bd3d39cdc111f70779cccdb750689

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -201 lines) Patch
M ios/chrome/browser/ui/contextual_search/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/contextual_search_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/contextual_search/contextual_search_controller.mm View 35 chunks +75 lines, -78 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/contextual_search_header_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/contextual_search/contextual_search_header_view.mm View 7 chunks +19 lines, -13 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/contextual_search_highlighter_view.mm View 3 chunks +6 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/contextual_search_mask_view.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/contextual_search_metrics.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.mm View 15 chunks +39 lines, -56 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/contextual_search_promo_view.mm View 11 chunks +18 lines, -17 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/contextual_search_results_view.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/contextual_search_results_view.mm View 8 chunks +12 lines, -8 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/contextual_search_web_state_observer.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/js_contextual_search_manager.mm View 1 chunk +4 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/contextual_search/panel_configuration.mm View 2 chunks +5 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator.mm View 7 chunks +8 lines, -8 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator_unittest.mm View 2 chunks +9 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/window_gesture_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/window_gesture_observer.mm View 2 chunks +9 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 9 (5 generated)
stkhapugin_OOO_until_May_30
PTAL. Patch set 1 is revert of revert. Patch set 2 is rebase of the ...
1 month, 2 weeks ago (2017-04-14 14:15:48 UTC) #3
marq (OOO until May 29)
lgtm
1 month, 2 weeks ago (2017-04-14 17:05:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824493002/40001
1 month, 1 week ago (2017-04-18 12:07:51 UTC) #6
commit-bot: I haz the power
1 month, 1 week ago (2017-04-18 13:33:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7affbfc7f68bd3d39cdc111f7077...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06