[ObjC ARC] Converts ios/chrome/browser/ui/contextual_search:contextual_search to ARC.

[ObjC ARC] Converts ios/chrome/browser/ui/contextual_search:contextual_search to ARC.

Automatically generated ARCMigrate commit
Notable issues:
 * In ContextualSearchController, there was a block with a weakSelf declared above it and never used. Replaced usage of self in the block with weakself.
* In window_gesture_observer had to suppress a warning, because ARC forbids calling arbitrary selectors. 

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2626073003
Cr-Commit-Position: refs/heads/master@{#444717}
Committed: https://chromium.googlesource.com/chromium/src/+/1c4c1a7db53cb254200e60dad098be6a655f2ad0

[stkhapugin, 2017-01-11 14:34:45]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 14:35:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 15:18:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 15:18:11]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[stkhapugin, 2017-01-11 17:33:58]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/contextual_search:contextual_search to
ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/contextual_search:contextual_search to
ARC.

Automatically generated ARCMigrate commit
Notable issues:
 * In ContextualSearchController, there was a block with a weakSelf declared
above it and never used. Replaced usage of self in the block with weakself.

BUG=624363
TEST=None
==========

[stkhapugin, 2017-01-11 17:38:02]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/contextual_search:contextual_search to
ARC.

Automatically generated ARCMigrate commit
Notable issues:
 * In ContextualSearchController, there was a block with a weakSelf declared
above it and never used. Replaced usage of self in the block with weakself.

BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/contextual_search:contextual_search to
ARC.

Automatically generated ARCMigrate commit
Notable issues:
 * In ContextualSearchController, there was a block with a weakSelf declared
above it and never used. Replaced usage of self in the block with weakself.
* In window_gesture_observer had to suppress a warning, because ARC forbids
calling arbitrary selectors. 

BUG=624363
TEST=None
==========

[stkhapugin, 2017-01-11 17:38:07]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 17:38:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 18:10:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 18:10:34]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[stkhapugin, 2017-01-12 15:44:49]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 15:45:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 16:43:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 16:43:42]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-01-13 10:23:03]

stkhapugin@chromium.org changed reviewers:
+ marq@chromium.org

[stkhapugin, 2017-01-13 10:23:03]

PTAL. Sorry for a large CL size, but changes are trivial

[marq (ping after 24h), 2017-01-13 10:38:18]

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.h
(right):

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.h:24:
@property(weak, nonatomic, readonly) PanelConfiguration* configuration;
Style nit: the atomicity attribute should come first.

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.mm
(right):

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.mm:52:
@property(weak, nonatomic, readonly) ContextualSearchPanelObservers* observers;
nonatomic, weak, readonly

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.mm:233:
base::mac::ScopedBlock<ProceduralBlockWithBool> completion;
Do we still need a scoped block under ARC?

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/contextual_search/contextual_search_results_view.mm
(right):

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/contextual_search/contextual_search_results_view.mm:25:
#error "This file requires ARC support."
No, seriously: this file requires ARC support. How many times do I have to tell
you?

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/contextual_search/contextual_search_web_state_observer.mm
(right):

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/contextual_search/contextual_search_web_state_observer.mm:12:
#error "This file requires ARC support."
Here, too.

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/contextual_search/panel_configuration.mm (right):

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/contextual_search/panel_configuration.mm:14: #error "This
file requires ARC support."
Clearly people aren't listening ...

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/contextual_search/window_gesture_observer.h (right):

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/contextual_search/window_gesture_observer.h:37:
@property(weak, nonatomic, readonly) UIView* touchedView;
nonatomic, weak, readonly

[stkhapugin, 2017-01-17 15:57:45]

PTAL

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.h
(right):

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.h:24:
@property(weak, nonatomic, readonly) PanelConfiguration* configuration;
On 2017/01/13 10:38:17, marq wrote:
> Style nit: the atomicity attribute should come first.

Done.

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.mm
(right):

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.mm:52:
@property(weak, nonatomic, readonly) ContextualSearchPanelObservers* observers;
On 2017/01/13 10:38:17, marq wrote:
> nonatomic, weak, readonly

Done, and actually changed to strong.

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/contextual_search/contextual_search_panel_view.mm:233:
base::mac::ScopedBlock<ProceduralBlockWithBool> completion;
On 2017/01/13 10:38:17, marq wrote:
> Do we still need a scoped block under ARC?

Done.

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/contextual_search/contextual_search_results_view.mm
(right):

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/contextual_search/contextual_search_results_view.mm:25:
#error "This file requires ARC support."
On 2017/01/13 10:38:17, marq wrote:
> No, seriously: this file requires ARC support. How many times do I have to
tell
> you?

Done.

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/contextual_search/contextual_search_web_state_observer.mm
(right):

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/contextual_search/contextual_search_web_state_observer.mm:12:
#error "This file requires ARC support."
On 2017/01/13 10:38:17, marq wrote:
> Here, too. 

Surely twice is the right amount.

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/contextual_search/panel_configuration.mm (right):

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/contextual_search/panel_configuration.mm:14: #error "This
file requires ARC support."
On 2017/01/13 10:38:18, marq wrote:
> Clearly people aren't listening ... 

Done.

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/contextual_search/window_gesture_observer.h (right):

https://codereview.chromium.org/2626073003/diff/60001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/contextual_search/window_gesture_observer.h:37:
@property(weak, nonatomic, readonly) UIView* touchedView;
On 2017/01/13 10:38:18, marq wrote:
> nonatomic, weak, readonly

Done.

[marq (ping after 24h), 2017-01-18 11:51:43]

lgtm

[stkhapugin, 2017-01-19 12:25:16]

The CQ bit was checked by stkhapugin@chromium.org

[commit-bot: I haz the power, 2017-01-19 12:25:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 13:17:24]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484828716181510,
"parent_rev": "c130dc3a4a7e9b8d17438f9d2c8b0d14bef9c08e", "commit_rev":
"1c4c1a7db53cb254200e60dad098be6a655f2ad0"}

[commit-bot: I haz the power, 2017-01-19 13:17:53]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/contextual_search:contextual_search to
ARC.

Automatically generated ARCMigrate commit
Notable issues:
 * In ContextualSearchController, there was a block with a weakSelf declared
above it and never used. Replaced usage of self in the block with weakself.
* In window_gesture_observer had to suppress a warning, because ARC forbids
calling arbitrary selectors. 

BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/contextual_search:contextual_search to
ARC.

Automatically generated ARCMigrate commit
Notable issues:
 * In ContextualSearchController, there was a block with a weakSelf declared
above it and never used. Replaced usage of self in the block with weakself.
* In window_gesture_observer had to suppress a warning, because ARC forbids
calling arbitrary selectors. 

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2626073003
Cr-Commit-Position: refs/heads/master@{#444717}
Committed:
https://chromium.googlesource.com/chromium/src/+/1c4c1a7db53cb254200e60dad098...
==========

[commit-bot: I haz the power, 2017-01-19 13:17:54]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/1c4c1a7db53cb254200e60dad098...