Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2824263002: Replace getBaseLayerSize() with the size passed to DrawingRecorder. (Closed)

Created:
3 years, 8 months ago by danakj
Modified:
3 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews, chromium-reviews, enne (OOO), kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace getBaseLayerSize() with the size passed to DrawingRecorder. The size passed to DrawingRecorder goes to SkPictureRecorder which goes to SkRecorder::reset() which goes to the canvas' device to set width and height that are returned from getBaseLayerSize(). Instead of this incredible journey, just use the size directly. R=pdr@chromium.org BUG=671433 Review-Url: https://codereview.chromium.org/2824263002 Cr-Commit-Position: refs/heads/master@{#465376} Committed: https://chromium.googlesource.com/chromium/src/+/eb2c3bd20976ffebd0b1610bb53e7cf78252796f

Patch Set 1 #

Total comments: 1

Patch Set 2 : scrollbarbaselayer: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
danakj
3 years, 8 months ago (2017-04-18 19:25:18 UTC) #2
danakj
https://codereview.chromium.org/2824263002/diff/1/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp File third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp (right): https://codereview.chromium.org/2824263002/diff/1/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp#newcode220 third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp:220: canvas->clear(SK_ColorRED); Oops bonus clear for testing.
3 years, 8 months ago (2017-04-18 19:27:12 UTC) #4
pdr.
LGTM, squash the journeys with great vengeance and furious anger
3 years, 8 months ago (2017-04-18 20:37:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824263002/20001
3 years, 8 months ago (2017-04-18 20:46:25 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 21:19:38 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eb2c3bd20976ffebd0b1610bb53e...

Powered by Google App Engine
This is Rietveld 408576698