|
|
DescriptionRemove PaintCanvas::getBaseLayerSize.
The method is now unused.
R=enne@chromium.org
BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2823253004
Cr-Original-Commit-Position: refs/heads/master@{#465423}
Committed: https://chromium.googlesource.com/chromium/src/+/efa3999f76e822cc9580cace498f3f778206a9dc
Review-Url: https://codereview.chromium.org/2823253004
Cr-Commit-Position: refs/heads/master@{#465674}
Committed: https://chromium.googlesource.com/chromium/src/+/5182e685304719922efc0082c28bbd6dd8ef59d7
Patch Set 1 #Patch Set 2 : baselayersize: . #
Messages
Total messages: 32 (22 generated)
Description was changed from ========== Remove PaintCanvas::getBaseLayerSize. The method is now unused. R=enne@chromium.org BUG=671433 ========== to ========== Remove PaintCanvas::getBaseLayerSize. The method is now unused. R=enne@chromium.org BUG=671433 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm *\o/*
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by danakj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1492558127620100, "parent_rev": "8982f602a8e1f521949d8dd8dae58cff1c787bec", "commit_rev": "efa3999f76e822cc9580cace498f3f778206a9dc"}
Message was sent while issue was closed.
Description was changed from ========== Remove PaintCanvas::getBaseLayerSize. The method is now unused. R=enne@chromium.org BUG=671433 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Remove PaintCanvas::getBaseLayerSize. The method is now unused. R=enne@chromium.org BUG=671433 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2823253004 Cr-Commit-Position: refs/heads/master@{#465423} Committed: https://chromium.googlesource.com/chromium/src/+/efa3999f76e822cc9580cace498f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/efa3999f76e822cc9580cace498f...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2820273004/ by findit-for-me@appspot.gserviceaccount.com. The reason for reverting is: Findit(https://goo.gl/kROfz5) identified CL at revision 465423 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....
Message was sent while issue was closed.
Patchset #2 (id:20001) has been deleted
Message was sent while issue was closed.
Description was changed from ========== Remove PaintCanvas::getBaseLayerSize. The method is now unused. R=enne@chromium.org BUG=671433 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2823253004 Cr-Commit-Position: refs/heads/master@{#465423} Committed: https://chromium.googlesource.com/chromium/src/+/efa3999f76e822cc9580cace498f... ========== to ========== Remove PaintCanvas::getBaseLayerSize. The method is now unused. R=enne@chromium.org BUG=671433 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2823253004 Cr-Commit-Position: refs/heads/master@{#465423} Committed: https://chromium.googlesource.com/chromium/src/+/efa3999f76e822cc9580cace498f... ==========
Updated GraphicsContextCanvasTest.mm which the CQ apparently ignored, and filed https://bugs.chromium.org/p/chromium/issues/detail?id=713180 about this.
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
danakj@chromium.org changed reviewers: + pdr@chromium.org
+pdr for webkit
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:40001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/04/19 at 14:24:55, danakj wrote: > +pdr for webkit LGTM
The CQ bit was checked by danakj@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org Link to the patchset: https://codereview.chromium.org/2823253004/#ps60001 (title: "baselayersize: .")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492625468651600, "parent_rev": "69dd6905cf64dd3943c60fca73d6158236fbd8c8", "commit_rev": "5182e685304719922efc0082c28bbd6dd8ef59d7"}
Message was sent while issue was closed.
Description was changed from ========== Remove PaintCanvas::getBaseLayerSize. The method is now unused. R=enne@chromium.org BUG=671433 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2823253004 Cr-Commit-Position: refs/heads/master@{#465423} Committed: https://chromium.googlesource.com/chromium/src/+/efa3999f76e822cc9580cace498f... ========== to ========== Remove PaintCanvas::getBaseLayerSize. The method is now unused. R=enne@chromium.org BUG=671433 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2823253004 Cr-Original-Commit-Position: refs/heads/master@{#465423} Committed: https://chromium.googlesource.com/chromium/src/+/efa3999f76e822cc9580cace498f... Review-Url: https://codereview.chromium.org/2823253004 Cr-Commit-Position: refs/heads/master@{#465674} Committed: https://chromium.googlesource.com/chromium/src/+/5182e685304719922efc0082c28b... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://chromium.googlesource.com/chromium/src/+/5182e685304719922efc0082c28b... |