Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2823253004: Remove PaintCanvas::getBaseLayerSize. (Closed)

Created:
3 years, 8 months ago by danakj
Modified:
3 years, 8 months ago
Reviewers:
pdr., enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PaintCanvas::getBaseLayerSize. The method is now unused. R=enne@chromium.org BUG=671433 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2823253004 Cr-Original-Commit-Position: refs/heads/master@{#465423} Committed: https://chromium.googlesource.com/chromium/src/+/efa3999f76e822cc9580cace498f3f778206a9dc Review-Url: https://codereview.chromium.org/2823253004 Cr-Commit-Position: refs/heads/master@{#465674} Committed: https://chromium.googlesource.com/chromium/src/+/5182e685304719922efc0082c28bbd6dd8ef59d7

Patch Set 1 #

Patch Set 2 : baselayersize: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M cc/paint/paint_canvas.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/paint/skia_paint_canvas.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/paint/skia_paint_canvas.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/mac/GraphicsContextCanvasTest.mm View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 32 (22 generated)
danakj
3 years, 8 months ago (2017-04-18 21:42:34 UTC) #2
enne (OOO)
lgtm *\o/*
3 years, 8 months ago (2017-04-18 21:43:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823253004/1
3 years, 8 months ago (2017-04-18 23:29:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/efa3999f76e822cc9580cace498f3f778206a9dc
3 years, 8 months ago (2017-04-18 23:36:18 UTC) #12
findit-for-me
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2820273004/ by findit-for-me@appspot.gserviceaccount.com. ...
3 years, 8 months ago (2017-04-18 23:53:50 UTC) #13
danakj
Updated GraphicsContextCanvasTest.mm which the CQ apparently ignored, and filed https://bugs.chromium.org/p/chromium/issues/detail?id=713180 about this.
3 years, 8 months ago (2017-04-19 14:24:23 UTC) #16
danakj
+pdr for webkit
3 years, 8 months ago (2017-04-19 14:24:55 UTC) #19
pdr.
On 2017/04/19 at 14:24:55, danakj wrote: > +pdr for webkit LGTM
3 years, 8 months ago (2017-04-19 17:48:52 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823253004/60001
3 years, 8 months ago (2017-04-19 18:12:02 UTC) #29
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 18:20:27 UTC) #32
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5182e685304719922efc0082c28b...

Powered by Google App Engine
This is Rietveld 408576698