Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1462)

Unified Diff: remoting/remoting_locales.gni

Issue 2824173004: Fix packing localized strings for //remoting. (Closed)
Patch Set: Address comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/resources/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/remoting_locales.gni
diff --git a/remoting/remoting_locales.gni b/remoting/remoting_locales.gni
index a9702de66ef8688e85f12308268e3b4848b0dc80..3dfd0a3047a3ed4402b3a168771153b50869da31 100644
--- a/remoting/remoting_locales.gni
+++ b/remoting/remoting_locales.gni
@@ -19,7 +19,6 @@ remoting_locales = [
"en",
"en-GB",
"es",
- "es-419",
"et",
"fa",
@@ -48,7 +47,6 @@ remoting_locales = [
"nb",
"nl",
"pl",
- "pt-BR",
"pt-PT",
"ro",
"ru",
@@ -73,38 +71,50 @@ remoting_locales = [
remoting_locales_with_underscores = remoting_locales
remoting_locales_with_underscores -= [
"en-GB",
- "es-419",
"fake-bidi",
- "pt-BR",
"pt-PT",
"zh-CN",
"zh-TW",
]
remoting_locales_with_underscores += [
"en_GB",
- "es_419",
"fake_bidi",
- "pt_BR",
"pt_PT",
"zh_CN",
"zh_TW",
]
-if (is_chromeos) {
+# An additional locale "en-US" is generated for ChromeOS and Chrome on iOS.
+if (is_chromeos || is_ios) {
remoting_locales += [ "en-US" ]
remoting_locales_with_underscores += [ "en_US" ]
}
-messages_locales = remoting_locales_with_underscores
-if (!is_chromeos) {
- # The messages output includes a separate one for en-US that the pak ones
- # don't have. We don't need to do this on ChromeOS since en_US is in the
- # locales list be default there.
- messages_locales += [ "en_US" ]
+# Locales "pt-BR" and "es-419" are named "pt" and "es-MX" respectively on iOS.
+if (!is_ios) {
+ remoting_locales += [
+ "pt-BR",
+ "es-419",
+ ]
+ remoting_locales_with_underscores += [
+ "pt_BR",
+ "es_419",
+ ]
+} else {
+ remoting_locales += [
+ "pt",
+ "es-MX",
+ ]
+ remoting_locales_with_underscores += [
+ "pt",
+ "es_MX",
+ ]
}
+messages_locales = remoting_locales_with_underscores
+
remoting_android_locales = [
"am",
"ar",
« no previous file with comments | « no previous file | remoting/resources/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698