Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1953)

Unified Diff: remoting/resources/BUILD.gn

Issue 2824173004: Fix packing localized strings for //remoting. (Closed)
Patch Set: Address comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/remoting_locales.gni ('k') | remoting/resources/remoting_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/resources/BUILD.gn
diff --git a/remoting/resources/BUILD.gn b/remoting/resources/BUILD.gn
index 3cc91d80167efed6b49f48d19ada60805208a4a1..a12b0e24a585112e7c0188cc653937f852a8677d 100644
--- a/remoting/resources/BUILD.gn
+++ b/remoting/resources/BUILD.gn
@@ -47,7 +47,7 @@ action("verify_resources") {
inputs = [ "remoting_strings.grd" ] + sources_to_verify
- stampfile = "$root_build_dir/remoting_resources_verified_stamp"
+ stampfile = "$root_out_dir/remoting_resources_verified_stamp"
outputs = [
stampfile,
]
@@ -115,8 +115,9 @@ action("copy_locales") {
# replacement over the locales. Here, we can do this in GN script by
# pretending the locale list is a list of files. The {{source_name_part}}
# will just expand to the locale name.
- inputs = process_file_template(remoting_locales,
- [ "$target_gen_dir/{{source_name_part}}.pak" ])
+ inputs = process_file_template(
+ remoting_locales,
+ [ "$root_gen_dir/remoting/resources/{{source_name_part}}.pak" ])
# Likewise, process the outputs in the same way as the inputs.
if (is_mac || is_ios) {
@@ -124,11 +125,11 @@ action("copy_locales") {
# different place.
outputs = process_file_template(
remoting_locales_with_underscores,
- [ "$root_build_dir/remoting/resources/{{source_name_part}}.lproj/locale.pak" ])
+ [ "$root_out_dir/remoting/resources/{{source_name_part}}.lproj/locale.pak" ])
} else {
outputs = process_file_template(
remoting_locales,
- [ "$root_build_dir/remoting_locales/{{source_name_part}}.pak" ])
+ [ "$root_out_dir/remoting_locales/{{source_name_part}}.pak" ])
}
args = [
« no previous file with comments | « remoting/remoting_locales.gni ('k') | remoting/resources/remoting_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698