Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2824123002: SELECT popup: Fix OPTGROUP rendering on a device with a touch-screen. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by tkent
Modified:
2 months, 1 week ago
Reviewers:
keishi
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

SELECT popup: Fix OPTGROUP rendering on a device with a touch-screen. We should not apply display:flex to OPTGROUP elements in popups. BUG=712107 Review-Url: https://codereview.chromium.org/2824123002 Cr-Commit-Position: refs/heads/master@{#465174} Committed: https://chromium.googlesource.com/chromium/src/+/db9cef9964f34067223f3d95f8a0206a3d07254b

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove padding-bottom #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-appearance-coarse.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/select-popup/popup-menu-appearance-coarse-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 19 (12 generated)
tkent
keishi, would you review this please? For now, OPTIONs in an OPTGROUP are laid out ...
2 months, 1 week ago (2017-04-18 04:48:48 UTC) #4
keishi
https://codereview.chromium.org/2824123002/diff/1/third_party/WebKit/Source/web/PopupMenuImpl.cpp File third_party/WebKit/Source/web/PopupMenuImpl.cpp (right): https://codereview.chromium.org/2824123002/diff/1/third_party/WebKit/Source/web/PopupMenuImpl.cpp#newcode277 third_party/WebKit/Source/web/PopupMenuImpl.cpp:277: "padding-bottom: %dpx;" Do we want to add a padding ...
2 months, 1 week ago (2017-04-18 05:45:49 UTC) #7
tkent
https://codereview.chromium.org/2824123002/diff/1/third_party/WebKit/Source/web/PopupMenuImpl.cpp File third_party/WebKit/Source/web/PopupMenuImpl.cpp (right): https://codereview.chromium.org/2824123002/diff/1/third_party/WebKit/Source/web/PopupMenuImpl.cpp#newcode277 third_party/WebKit/Source/web/PopupMenuImpl.cpp:277: "padding-bottom: %dpx;" On 2017/04/18 at 05:45:49, keishi wrote: > ...
2 months, 1 week ago (2017-04-18 06:04:49 UTC) #8
tkent
uploaded new patch set.
2 months, 1 week ago (2017-04-18 06:11:23 UTC) #9
keishi
On 2017/04/18 06:11:23, tkent wrote: > uploaded new patch set. LGTM I guess this is ...
2 months, 1 week ago (2017-04-18 06:55:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824123002/20001
2 months, 1 week ago (2017-04-18 07:56:38 UTC) #16
commit-bot: I haz the power
2 months, 1 week ago (2017-04-18 08:01:13 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/db9cef9964f34067223f3d95f8a0...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318