third_party/WebKit/Source/web/PopupMenuImpl.cpp - Issue 2824123002: SELECT popup: Fix OPTGROUP rendering on a device with a touch-screen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/PopupMenuImpl.cpp

Issue 2824123002: SELECT popup: Fix OPTGROUP rendering on a device with a touch-screen. (Closed)

Patch Set: remove padding-bottom Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/PopupMenuImpl.cpp

diff --git a/third_party/WebKit/Source/web/PopupMenuImpl.cpp b/third_party/WebKit/Source/web/PopupMenuImpl.cpp

index 5186a47f77fde5c402c122d0396ba40f4e8f9ce9..fcb0db78a39a26bfc7fdb06c66d47e5567de08ee 100644

--- a/third_party/WebKit/Source/web/PopupMenuImpl.cpp

+++ b/third_party/WebKit/Source/web/PopupMenuImpl.cpp

@@ -274,6 +274,8 @@ void PopupMenuImpl::WriteDocument(SharedBuffer* data) {

int min_height = static_cast<int>(roundf(24 * scale_factor));

PagePopupClient::AddString(String::Format("option, optgroup {"

"padding-top: %dpx;"

+ "}\n"

+ "option {"

"padding-bottom: %dpx;"

"min-height: %dpx;"

"display: flex;"