Various logical fixes for jumplist

Various logical fixes for jumplist

This CL consists of the following three changes:

1) Move DeleteDirectoryContentAndLogResults() so that it runs only if 
   jumplist_updater.BeginUpdate() succeeds, otherwise it's pointless.

2) Return early if any AddShellLink call fails. This is suspected to 
   cause long execution time for jumplist_updater.

3) Decrease kFileDeleteLimit from 60 to 30. A user without jumplist
   issues should have at most 10 icon files in JumpListIcons folder as 
   in crrev.com/2816113002. So changing kFileDeleteLimit to 30 won't 
   affect "healthy" users. It'll give a better experience for users 
   who have corrupted jumplist folders as the disk IO per jumplist 
   update becomes less.

BUG=40407, 179576
Review-Url: https://codereview.chromium.org/2824103003
Cr-Commit-Position: refs/heads/master@{#465689}
Committed: https://chromium.googlesource.com/chromium/src/+/45d7b0fd5122143bca4dfc84370e11d7594cd411

[chengx, 2017-04-18 21:22:37]

The CQ bit was checked by chengx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 21:23:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chengx, 2017-04-18 21:54:27]

Description was changed from

==========
Various updates for jumplist*

BUG=40407, 179576
==========

to

==========
Various logical fixes for jumplist

This CL consists of the following three improvements:
1) Do DeleteDirectoryContentAndLogResults() only if 
jumplist_updater.BeginUpdate() succeeds, otherwise it's pointless.
2) Return early if any AddShellLink call fails. This is suspected to cause long
execution time of jumplist_updater.
3) Decrease kFileDeleteLimit from 60 to 30. A user without jumplist
issues should have at most 10 icon files in JumpListIcons folder after
landing crrev.com/2816113002. So changing kFileDeleteLimit to 30 won't
affect "healthy" users.

BUG=40407, 179576
==========

[chengx, 2017-04-18 21:54:38]

Description was changed from

==========
Various logical fixes for jumplist

This CL consists of the following three improvements:
1) Do DeleteDirectoryContentAndLogResults() only if 
jumplist_updater.BeginUpdate() succeeds, otherwise it's pointless.
2) Return early if any AddShellLink call fails. This is suspected to cause long
execution time of jumplist_updater.
3) Decrease kFileDeleteLimit from 60 to 30. A user without jumplist
issues should have at most 10 icon files in JumpListIcons folder after
landing crrev.com/2816113002. So changing kFileDeleteLimit to 30 won't
affect "healthy" users.

BUG=40407, 179576
==========

to

==========
Various logical fixes for jumplist

This CL consists of the following three improvements:
1) Do DeleteDirectoryContentAndLogResults() only if 
jumplist_updater.BeginUpdate() succeeds, otherwise it's pointless.
2) Return early if any AddShellLink call fails. This is suspected to 
cause long execution time of jumplist_updater.
3) Decrease kFileDeleteLimit from 60 to 30. A user without jumplist
issues should have at most 10 icon files in JumpListIcons folder after
landing crrev.com/2816113002. So changing kFileDeleteLimit to 30 won't
affect "healthy" users.

BUG=40407, 179576
==========

[chengx, 2017-04-18 21:55:23]

Description was changed from

==========
Various logical fixes for jumplist

This CL consists of the following three improvements:
1) Do DeleteDirectoryContentAndLogResults() only if 
jumplist_updater.BeginUpdate() succeeds, otherwise it's pointless.
2) Return early if any AddShellLink call fails. This is suspected to 
cause long execution time of jumplist_updater.
3) Decrease kFileDeleteLimit from 60 to 30. A user without jumplist
issues should have at most 10 icon files in JumpListIcons folder after
landing crrev.com/2816113002. So changing kFileDeleteLimit to 30 won't
affect "healthy" users.

BUG=40407, 179576
==========

to

==========
Various logical fixes for jumplist

This CL consists of the following three improvements:
1) Do DeleteDirectoryContentAndLogResults() only if 
   jumplist_updater.BeginUpdate() succeeds, otherwise it's pointless.
2) Return early if any AddShellLink call fails. This is suspected to 
   cause long execution time of jumplist_updater.
3) Decrease kFileDeleteLimit from 60 to 30. A user without jumplist
   issues should have at most 10 icon files in JumpListIcons folder 
   after landing crrev.com/2816113002. So changing kFileDeleteLimit to 
   30 won't affect "healthy" users.

BUG=40407, 179576
==========

[chengx, 2017-04-18 21:57:26]

Description was changed from

==========
Various logical fixes for jumplist

This CL consists of the following three improvements:
1) Do DeleteDirectoryContentAndLogResults() only if 
   jumplist_updater.BeginUpdate() succeeds, otherwise it's pointless.
2) Return early if any AddShellLink call fails. This is suspected to 
   cause long execution time of jumplist_updater.
3) Decrease kFileDeleteLimit from 60 to 30. A user without jumplist
   issues should have at most 10 icon files in JumpListIcons folder 
   after landing crrev.com/2816113002. So changing kFileDeleteLimit to 
   30 won't affect "healthy" users.

BUG=40407, 179576
==========

to

==========
Various logical fixes for jumplist

This CL consists of the following three changes:
1) Do DeleteDirectoryContentAndLogResults() only if 
   jumplist_updater.BeginUpdate() succeeds, otherwise it's pointless.
2) Return early if any AddShellLink call fails. This is suspected to 
   cause long execution time of jumplist_updater.
3) Decrease kFileDeleteLimit from 60 to 30. A user without jumplist
   issues should have at most 10 icon files in JumpListIcons folder 
   after landing crrev.com/2816113002. So changing kFileDeleteLimit to 
   30 won't affect "healthy" users. It'll give a better experience for
   users who has corrupted jumplist folder as the disk IO per update 
   is less.

BUG=40407, 179576
==========

[chengx, 2017-04-18 21:58:57]

Description was changed from

==========
Various logical fixes for jumplist

This CL consists of the following three changes:
1) Do DeleteDirectoryContentAndLogResults() only if 
   jumplist_updater.BeginUpdate() succeeds, otherwise it's pointless.
2) Return early if any AddShellLink call fails. This is suspected to 
   cause long execution time of jumplist_updater.
3) Decrease kFileDeleteLimit from 60 to 30. A user without jumplist
   issues should have at most 10 icon files in JumpListIcons folder 
   after landing crrev.com/2816113002. So changing kFileDeleteLimit to 
   30 won't affect "healthy" users. It'll give a better experience for
   users who has corrupted jumplist folder as the disk IO per update 
   is less.

BUG=40407, 179576
==========

to

==========
Various logical fixes for jumplist

This CL consists of the following three changes:

1) Do DeleteDirectoryContentAndLogResults() only if 
   jumplist_updater.BeginUpdate() succeeds, otherwise it's pointless.

2) Return early if any AddShellLink call fails. This is suspected to 
   cause long execution time for jumplist_updater.

3) Decrease kFileDeleteLimit from 60 to 30. A user without jumplist
   issues should have at most 10 icon files in JumpListIcons folder 
   after landing crrev.com/2816113002. So changing kFileDeleteLimit to 
   30 won't affect "healthy" users. It'll give a better experience for
   users who have corrupted jumplist folders as the disk IO per update 
   becomes less.

BUG=40407, 179576
==========

[chengx, 2017-04-18 22:01:09]

chengx@chromium.org changed reviewers:
+ pmonette@chromium.org

[chengx, 2017-04-18 22:01:09]

PTAL this small CL. Thanks!

[commit-bot: I haz the power, 2017-04-18 22:03:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 22:03:00]

Dry run: This issue passed the CQ dry run.

[chengx, 2017-04-18 22:08:59]

Description was changed from

==========
Various logical fixes for jumplist

This CL consists of the following three changes:

1) Do DeleteDirectoryContentAndLogResults() only if 
   jumplist_updater.BeginUpdate() succeeds, otherwise it's pointless.

2) Return early if any AddShellLink call fails. This is suspected to 
   cause long execution time for jumplist_updater.

3) Decrease kFileDeleteLimit from 60 to 30. A user without jumplist
   issues should have at most 10 icon files in JumpListIcons folder 
   after landing crrev.com/2816113002. So changing kFileDeleteLimit to 
   30 won't affect "healthy" users. It'll give a better experience for
   users who have corrupted jumplist folders as the disk IO per update 
   becomes less.

BUG=40407, 179576
==========

to

==========
Various logical fixes for jumplist

This CL consists of the following three changes:

1) Do DeleteDirectoryContentAndLogResults() only if 
   jumplist_updater.BeginUpdate() succeeds, otherwise it's pointless.

2) Return early if any AddShellLink call fails. This is suspected to 
   cause long execution time for jumplist_updater.

3) Decrease kFileDeleteLimit from 60 to 30. A user without jumplist
   issues should have at most 10 icon files in JumpListIcons folder 
   as in crrev.com/2816113002. So changing kFileDeleteLimit to 
   30 won't affect "healthy" users. It'll give a better experience for
   users who have corrupted jumplist folders as the disk IO per update 
   becomes less.

BUG=40407, 179576
==========

[chengx, 2017-04-18 22:21:59]

Description was changed from

==========
Various logical fixes for jumplist

This CL consists of the following three changes:

1) Do DeleteDirectoryContentAndLogResults() only if 
   jumplist_updater.BeginUpdate() succeeds, otherwise it's pointless.

2) Return early if any AddShellLink call fails. This is suspected to 
   cause long execution time for jumplist_updater.

3) Decrease kFileDeleteLimit from 60 to 30. A user without jumplist
   issues should have at most 10 icon files in JumpListIcons folder 
   as in crrev.com/2816113002. So changing kFileDeleteLimit to 
   30 won't affect "healthy" users. It'll give a better experience for
   users who have corrupted jumplist folders as the disk IO per update 
   becomes less.

BUG=40407, 179576
==========

to

==========
Various logical fixes for jumplist

This CL consists of the following three changes:

1) Move DeleteDirectoryContentAndLogResults() so that it runs only if 
   jumplist_updater.BeginUpdate() succeeds, otherwise it's pointless.

2) Return early if any AddShellLink call fails. This is suspected to 
   cause long execution time for jumplist_updater.

3) Decrease kFileDeleteLimit from 60 to 30. A user without jumplist
   issues should have at most 10 icon files in JumpListIcons folder 
   as in crrev.com/2816113002. So changing kFileDeleteLimit to 
   30 won't affect "healthy" users. It'll give a better experience for
   users who have corrupted jumplist folders as the disk IO per update 
   becomes less.

BUG=40407, 179576
==========

[chengx, 2017-04-18 22:22:36]

Description was changed from

==========
Various logical fixes for jumplist

This CL consists of the following three changes:

1) Move DeleteDirectoryContentAndLogResults() so that it runs only if 
   jumplist_updater.BeginUpdate() succeeds, otherwise it's pointless.

2) Return early if any AddShellLink call fails. This is suspected to 
   cause long execution time for jumplist_updater.

3) Decrease kFileDeleteLimit from 60 to 30. A user without jumplist
   issues should have at most 10 icon files in JumpListIcons folder 
   as in crrev.com/2816113002. So changing kFileDeleteLimit to 
   30 won't affect "healthy" users. It'll give a better experience for
   users who have corrupted jumplist folders as the disk IO per update 
   becomes less.

BUG=40407, 179576
==========

to

==========
Various logical fixes for jumplist

This CL consists of the following three changes:

1) Move DeleteDirectoryContentAndLogResults() so that it runs only if 
   jumplist_updater.BeginUpdate() succeeds, otherwise it's pointless.

2) Return early if any AddShellLink call fails. This is suspected to 
   cause long execution time for jumplist_updater.

3) Decrease kFileDeleteLimit from 60 to 30. A user without jumplist
   issues should have at most 10 icon files in JumpListIcons folder 
   as in crrev.com/2816113002. So changing kFileDeleteLimit to 
   30 won't affect "healthy" users. It'll give a better experience for
   users who have corrupted jumplist folders as the disk IO per 
   jumplist update becomes less.

BUG=40407, 179576
==========

[chengx, 2017-04-18 22:23:12]

Description was changed from

==========
Various logical fixes for jumplist

This CL consists of the following three changes:

1) Move DeleteDirectoryContentAndLogResults() so that it runs only if 
   jumplist_updater.BeginUpdate() succeeds, otherwise it's pointless.

2) Return early if any AddShellLink call fails. This is suspected to 
   cause long execution time for jumplist_updater.

3) Decrease kFileDeleteLimit from 60 to 30. A user without jumplist
   issues should have at most 10 icon files in JumpListIcons folder 
   as in crrev.com/2816113002. So changing kFileDeleteLimit to 
   30 won't affect "healthy" users. It'll give a better experience for
   users who have corrupted jumplist folders as the disk IO per 
   jumplist update becomes less.

BUG=40407, 179576
==========

to

==========
Various logical fixes for jumplist

This CL consists of the following three changes:

1) Move DeleteDirectoryContentAndLogResults() so that it runs only if 
   jumplist_updater.BeginUpdate() succeeds, otherwise it's pointless.

2) Return early if any AddShellLink call fails. This is suspected to 
   cause long execution time for jumplist_updater.

3) Decrease kFileDeleteLimit from 60 to 30. A user without jumplist
   issues should have at most 10 icon files in JumpListIcons folder as 
   in crrev.com/2816113002. So changing kFileDeleteLimit to 30 won't 
   affect "healthy" users. It'll give a better experience for users 
   who have corrupted jumplist folders as the disk IO per jumplist 
   update becomes less.

BUG=40407, 179576
==========

[chengx, 2017-04-19 18:29:32]

Gentle Ping~

Hi Patrick, it seems you are 3 hours ahead of me, so I'll ping now for the day.
Thanks a lot!

[Patrick Monette, 2017-04-19 18:48:40]

lgtm

[chengx, 2017-04-19 18:57:20]

The CQ bit was checked by chengx@chromium.org

[commit-bot: I haz the power, 2017-04-19 18:57:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 19:05:05]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492628240505200, "parent_rev":
"77f3542894742c1351f9a02638f46752e6db9c40", "commit_rev":
"45d7b0fd5122143bca4dfc84370e11d7594cd411"}

[commit-bot: I haz the power, 2017-04-19 19:05:12]

Description was changed from

==========
Various logical fixes for jumplist

This CL consists of the following three changes:

1) Move DeleteDirectoryContentAndLogResults() so that it runs only if 
   jumplist_updater.BeginUpdate() succeeds, otherwise it's pointless.

2) Return early if any AddShellLink call fails. This is suspected to 
   cause long execution time for jumplist_updater.

3) Decrease kFileDeleteLimit from 60 to 30. A user without jumplist
   issues should have at most 10 icon files in JumpListIcons folder as 
   in crrev.com/2816113002. So changing kFileDeleteLimit to 30 won't 
   affect "healthy" users. It'll give a better experience for users 
   who have corrupted jumplist folders as the disk IO per jumplist 
   update becomes less.

BUG=40407, 179576
==========

to

==========
Various logical fixes for jumplist

This CL consists of the following three changes:

1) Move DeleteDirectoryContentAndLogResults() so that it runs only if 
   jumplist_updater.BeginUpdate() succeeds, otherwise it's pointless.

2) Return early if any AddShellLink call fails. This is suspected to 
   cause long execution time for jumplist_updater.

3) Decrease kFileDeleteLimit from 60 to 30. A user without jumplist
   issues should have at most 10 icon files in JumpListIcons folder as 
   in crrev.com/2816113002. So changing kFileDeleteLimit to 30 won't 
   affect "healthy" users. It'll give a better experience for users 
   who have corrupted jumplist folders as the disk IO per jumplist 
   update becomes less.

BUG=40407, 179576

Review-Url: https://codereview.chromium.org/2824103003
Cr-Commit-Position: refs/heads/master@{#465689}
Committed:
https://chromium.googlesource.com/chromium/src/+/45d7b0fd5122143bca4dfc84370e...
==========

[commit-bot: I haz the power, 2017-04-19 19:05:13]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/45d7b0fd5122143bca4dfc84370e...