Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4530)

Unified Diff: chrome/browser/win/jumplist_updater.cc

Issue 2824103003: Various logical fixes for jumplist (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/win/jumplist_file_util.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/win/jumplist_updater.cc
diff --git a/chrome/browser/win/jumplist_updater.cc b/chrome/browser/win/jumplist_updater.cc
index df7c772bee1184316eb7c2ce58f83f25bad9aa72..7d4658b5c8177cfc337d337cd9f7641de952ec0d 100644
--- a/chrome/browser/win/jumplist_updater.cc
+++ b/chrome/browser/win/jumplist_updater.cc
@@ -190,7 +190,8 @@ bool JumpListUpdater::AddTasks(const ShellLinkItemList& link_items) {
// Add items to the "Task" category.
for (ShellLinkItemList::const_iterator it = link_items.begin();
it != link_items.end(); ++it) {
- AddShellLink(collection, application_path.value(), *it);
+ if (!AddShellLink(collection, application_path.value(), *it))
+ return false;
}
// We can now add the new list to the JumpList.
@@ -236,8 +237,8 @@ bool JumpListUpdater::AddCustomCategory(const std::wstring& category_name,
for (ShellLinkItemList::const_iterator item = link_items.begin();
item != link_items.end() && max_items > 0; ++item, --max_items) {
- scoped_refptr<ShellLinkItem> link(*item);
- AddShellLink(collection, application_path.value(), link);
+ if (!AddShellLink(collection, application_path.value(), *item))
+ return false;
}
// We can now add the new list to the JumpList.
« no previous file with comments | « chrome/browser/win/jumplist_file_util.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698