Issue 2824063002: [sync] Instantiate the platform appropriate SyncedTabDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2824063002: [sync] Instantiate the platform appropriate SyncedTabDelegate (Closed)

Created:
3 years, 8 months ago by skym

Modified:
3 years, 8 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

[sync] Instantiate the platform appropriate SyncedTabDelegate SyncSessionsWebContentsRouter accesses an instance of the TabContentsSyncedTabDelegate directly on Android when it should use SyncedTabDelegateAndroid instead. This change fixes that. R=zea@chromium.org BUG=711847 Review-Url: https://codereview.chromium.org/2823843003 Cr-Commit-Position: refs/heads/master@{#464963} (cherry picked from commit 66da2b8252ada18ba7e5644eeee0ee089977d3be) Review-Url: https://codereview.chromium.org/2824063002 . Cr-Commit-Position: refs/branch-heads/3071@{#27} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/c830170807ad321ff02c1e6e023fe7a0b1e4c43d

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	chrome/browser/sync/sessions/sync_sessions_web_contents_router.cc	View		3 chunks	+19 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

skym

3 years, 8 months ago (2017-04-17 23:38:46 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c830170807ad321ff02c1e6e023fe7a0b1e4c43d.