Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2824063002: [sync] Instantiate the platform appropriate SyncedTabDelegate (Closed)

Created:
3 years, 8 months ago by skym
Modified:
3 years, 8 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[sync] Instantiate the platform appropriate SyncedTabDelegate SyncSessionsWebContentsRouter accesses an instance of the TabContentsSyncedTabDelegate directly on Android when it should use SyncedTabDelegateAndroid instead. This change fixes that. R=zea@chromium.org BUG=711847 Review-Url: https://codereview.chromium.org/2823843003 Cr-Commit-Position: refs/heads/master@{#464963} (cherry picked from commit 66da2b8252ada18ba7e5644eeee0ee089977d3be) Review-Url: https://codereview.chromium.org/2824063002 . Cr-Commit-Position: refs/branch-heads/3071@{#27} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/c830170807ad321ff02c1e6e023fe7a0b1e4c43d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M chrome/browser/sync/sessions/sync_sessions_web_contents_router.cc View 3 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
skym
3 years, 8 months ago (2017-04-17 23:38:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c830170807ad321ff02c1e6e023fe7a0b1e4c43d.

Powered by Google App Engine
This is Rietveld 408576698