Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2823843003: [sync] Instantiate the platform appropriate SyncedTabDelegate (Closed)

Created:
3 years, 8 months ago by Patrick Noland
Modified:
3 years, 8 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[sync] Instantiate the platform appropriate SyncedTabDelegate SyncSessionsWebContentsRouter accesses an instance of the TabContentsSyncedTabDelegate directly on Android when it should use SyncedTabDelegateAndroid instead. This change fixes that. R=zea@chromium.org BUG=711847 Review-Url: https://codereview.chromium.org/2823843003 Cr-Commit-Position: refs/heads/master@{#464963} Committed: https://chromium.googlesource.com/chromium/src/+/66da2b8252ada18ba7e5644eeee0ee089977d3be

Patch Set 1 #

Patch Set 2 : Fix android compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M chrome/browser/sync/sessions/sync_sessions_web_contents_router.cc View 1 3 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
Nicolas Zea
LGTM given we want to fix this quickly. We'll probably want to merge this into ...
3 years, 8 months ago (2017-04-17 18:10:17 UTC) #7
Patrick Noland
On 2017/04/17 18:10:17, Nicolas Zea wrote: > LGTM given we want to fix this quickly. ...
3 years, 8 months ago (2017-04-17 18:51:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823843003/20001
3 years, 8 months ago (2017-04-17 18:52:48 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 18:57:54 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/66da2b8252ada18ba7e5644eeee0...

Powered by Google App Engine
This is Rietveld 408576698