[sync] Instantiate the platform appropriate SyncedTabDelegate

[sync] Instantiate the platform appropriate SyncedTabDelegate

SyncSessionsWebContentsRouter accesses an instance of the
TabContentsSyncedTabDelegate directly on Android when it should use
SyncedTabDelegateAndroid instead. This change fixes that.

R=zea@chromium.org

BUG=711847
Review-Url: https://codereview.chromium.org/2823843003
Cr-Commit-Position: refs/heads/master@{#464963}
Committed: https://chromium.googlesource.com/chromium/src/+/66da2b8252ada18ba7e5644eeee0ee089977d3be

[Patrick Noland, 2017-04-17 17:24:35]

The CQ bit was checked by pnoland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 17:24:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 17:51:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 17:51:49]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Patrick Noland, 2017-04-17 17:57:27]

The CQ bit was checked by pnoland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 17:57:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nicolas Zea, 2017-04-17 18:10:17]

LGTM given we want to fix this quickly. We'll probably want to merge this into
m59.

Separately, how difficult do you think would it be to add a test for this? I
suspect it would have to be a new sync instrumentation test (see for example
OpenTabsTest.java)

[commit-bot: I haz the power, 2017-04-17 18:48:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 18:48:23]

Dry run: This issue passed the CQ dry run.

[Patrick Noland, 2017-04-17 18:51:53]

On 2017/04/17 18:10:17, Nicolas Zea wrote:
> LGTM given we want to fix this quickly. We'll probably want to merge this into
> m59.
> 
> Separately, how difficult do you think would it be to add a test for this? I
> suspect it would have to be a new sync instrumentation test (see for example
> OpenTabsTest.java)

I'm not sure exactly, I'll try to come up with something that doesn't require
too much extra JNI plumbing.

[Patrick Noland, 2017-04-17 18:52:14]

The CQ bit was checked by pnoland@chromium.org

[commit-bot: I haz the power, 2017-04-17 18:52:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 18:57:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492455134706960,
"parent_rev": "e1979f60524da9dab9d8cc19a23910f8d5dcf180", "commit_rev":
"66da2b8252ada18ba7e5644eeee0ee089977d3be"}

[commit-bot: I haz the power, 2017-04-17 18:57:53]

Description was changed from

==========
[sync] Instantiate the platform appropriate SyncedTabDelegate

SyncSessionsWebContentsRouter accesses an instance of the
TabContentsSyncedTabDelegate directly on Android when it should use
SyncedTabDelegateAndroid instead. This change fixes that.

R=zea@chromium.org

BUG=711847
==========

to

==========
[sync] Instantiate the platform appropriate SyncedTabDelegate

SyncSessionsWebContentsRouter accesses an instance of the
TabContentsSyncedTabDelegate directly on Android when it should use
SyncedTabDelegateAndroid instead. This change fixes that.

R=zea@chromium.org

BUG=711847

Review-Url: https://codereview.chromium.org/2823843003
Cr-Commit-Position: refs/heads/master@{#464963}
Committed:
https://chromium.googlesource.com/chromium/src/+/66da2b8252ada18ba7e5644eeee0...
==========

[commit-bot: I haz the power, 2017-04-17 18:57:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/66da2b8252ada18ba7e5644eeee0...