Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2824003002: Revert of Remove Mac10.9 expectation for text-match-document-change-expected.png (Closed)

Created:
3 years, 8 months ago by alexmos
Modified:
3 years, 8 months ago
Reviewers:
Hwanseung Lee
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove Mac10.9 expectation for text-match-document-change-expected.png (patchset #2 id:20001 of https://codereview.chromium.org/2827453002/ ) Reason for revert: Didn't fix the Mac10.9 failures. The custom 10.9 expectation appears necessary, and should probably just be copied to the virtual/disable-spinvalidation one. Original issue's description: > Remove Mac10.9 expectation for text-match-document-change-expected.png > > The png for virtual/disable-spinvalidation/ appears to be broken anyway, and suspected to be causing > failures on > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/. > > A Mac image expectation was added in > https://codereview.chromium.org/2824653002 and should cover Mac10.9 > once this is removed. > > Also remove the non-virtual mac-mac10.9 png, as it appears to be the same as the more generic Mac png from https://codereview.chromium.org/2824653002. > > BUG=711689 > TBR=hs1217.lee@samsung.com > NOTRY=true > > Review-Url: https://codereview.chromium.org/2827453002 > Cr-Commit-Position: refs/heads/master@{#464932} > Committed: https://chromium.googlesource.com/chromium/src/+/0fe1451d08ef167436488e7dbacbd8d840a5c858 TBR=hs1217.lee@samsung.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=711689 Review-Url: https://codereview.chromium.org/2824003002 Cr-Commit-Position: refs/heads/master@{#465004} Committed: https://chromium.googlesource.com/chromium/src/+/ef07b23fe53c8640375d2d6421c22fc50b94cf9e

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
alexmos
Created Revert of Remove Mac10.9 expectation for text-match-document-change-expected.png
3 years, 8 months ago (2017-04-17 20:24:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824003002/1
3 years, 8 months ago (2017-04-17 20:24:55 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 20:34:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ef07b23fe53c8640375d2d6421c2...

Powered by Google App Engine
This is Rietveld 408576698