3 years, 8 months ago
(2017-04-17 16:31:05 UTC)
#2
PTAL
alexmos
Actually, I think we can remove the png for the non-virtual test as well. It's ...
3 years, 8 months ago
(2017-04-17 16:35:26 UTC)
#3
Actually, I think we can remove the png for the non-virtual test as well. It's
the same as the png one you added for all of Mac. I've updated this in PS2.
alexmos
Description was changed from ========== Remove Mac10.9 expectation for text-match-document-change-expected.png The png appears to be ...
3 years, 8 months ago
(2017-04-17 16:53:53 UTC)
#4
Description was changed from ========== Remove Mac10.9 expectation for text-match-document-change-expected.png The png for virtual/disable-spinvalidation/ appears ...
3 years, 8 months ago
(2017-04-17 16:55:02 UTC)
#5
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492448135771820, "parent_rev": "d1fc96d10bdc87cd447c5f95926eaefee6761d12", "commit_rev": "0fe1451d08ef167436488e7dbacbd8d840a5c858"}
3 years, 8 months ago
(2017-04-17 17:00:46 UTC)
#9
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492448135771820,
"parent_rev": "d1fc96d10bdc87cd447c5f95926eaefee6761d12", "commit_rev":
"0fe1451d08ef167436488e7dbacbd8d840a5c858"}
commit-bot: I haz the power
Description was changed from ========== Remove Mac10.9 expectation for text-match-document-change-expected.png The png for virtual/disable-spinvalidation/ appears ...
3 years, 8 months ago
(2017-04-17 17:00:55 UTC)
#10
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2824003002/ by alexmos@chromium.org. ...
3 years, 8 months ago
(2017-04-17 20:24:29 UTC)
#12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2824003002/ by alexmos@chromium.org.
The reason for reverting is: Didn't fix the Mac10.9 failures. The custom 10.9
expectation appears necessary, and should probably just be copied to the
virtual/disable-spinvalidation one..
Issue 2827453002: Remove Mac10.9 expectation for text-match-document-change-expected.png
(Closed)
Created 3 years, 8 months ago by alexmos
Modified 3 years, 8 months ago
Reviewers: Hwanseung Lee
Base URL:
Comments: 0