Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2827453002: Remove Mac10.9 expectation for text-match-document-change-expected.png (Closed)

Created:
3 years, 8 months ago by alexmos
Modified:
3 years, 8 months ago
Reviewers:
Hwanseung Lee
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Mac10.9 expectation for text-match-document-change-expected.png The png for virtual/disable-spinvalidation/ appears to be broken anyway, and suspected to be causing failures on https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/. A Mac image expectation was added in https://codereview.chromium.org/2824653002 and should cover Mac10.9 once this is removed. Also remove the non-virtual mac-mac10.9 png, as it appears to be the same as the more generic Mac png from https://codereview.chromium.org/2824653002. BUG=711689 TBR=hs1217.lee@samsung.com NOTRY=true Review-Url: https://codereview.chromium.org/2827453002 Cr-Commit-Position: refs/heads/master@{#464932} Committed: https://chromium.googlesource.com/chromium/src/+/0fe1451d08ef167436488e7dbacbd8d840a5c858

Patch Set 1 #

Patch Set 2 : Remove non-virtual image as well #

Messages

Total messages: 12 (6 generated)
alexmos
PTAL
3 years, 8 months ago (2017-04-17 16:31:05 UTC) #2
alexmos
Actually, I think we can remove the png for the non-virtual test as well. It's ...
3 years, 8 months ago (2017-04-17 16:35:26 UTC) #3
alexmos
I'll go ahead and land this to get the bot green, but please let me ...
3 years, 8 months ago (2017-04-17 16:55:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827453002/20001
3 years, 8 months ago (2017-04-17 16:56:11 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/0fe1451d08ef167436488e7dbacbd8d840a5c858
3 years, 8 months ago (2017-04-17 17:00:57 UTC) #11
alexmos
3 years, 8 months ago (2017-04-17 20:24:29 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2824003002/ by alexmos@chromium.org.

The reason for reverting is: Didn't fix the Mac10.9 failures.  The custom 10.9
expectation appears necessary, and should probably just be copied to the
virtual/disable-spinvalidation one..

Powered by Google App Engine
This is Rietveld 408576698