Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2823923002:
[Extensions] Only add traffic management headers for webstore updates (Closed)
Description[Extensions] Only add traffic management headers for webstore updates
Instead of adding traffic management headers for all update pings, only
include them for pings sent to the webstore.
BUG=647516
Review-Url: https://codereview.chromium.org/2823923002
Cr-Commit-Position: refs/heads/master@{#465668}
Committed: https://chromium.googlesource.com/chromium/src/+/70dab6f4ff7ddadd4b1da803bfb0baf93a8f0512
Patch Set 1 #
Total comments: 2
Patch Set 2 : const-ify #
Messages
Total messages: 22 (14 generated)
Description was changed from ========== format foo BUG= ========== to ========== [Extensions] Only add traffic management headers for webstore updates Instead of adding traffic management headers for all update pings, only include them for pings sent to the webstore. BUG=647516 ==========
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rdevlin.cronin@chromium.org changed reviewers: + mxnguyen@chromium.org, sorin@chromium.org
Hey folks, mind taking a look? It occurred to me after crrev.com/b764761949ea8376c93fb682ca51a29852e6f39f landed that we should probably only do this for the webstore.
On 2017/04/18 19:37:23, Devlin wrote: > Hey folks, mind taking a look? It occurred to me after > crrev.com/b764761949ea8376c93fb682ca51a29852e6f39f landed that we should > probably only do this for the webstore. LGTM. From my understanding, most extensions updates are now hosted by webstore right?
lgtm
On 2017/04/18 20:53:33, Minh X. Nguyen wrote: > From my understanding, most extensions updates are now hosted by webstore right? Yes, the vast majority are, but there are exceptions for some policy-installed extensions and on linux.
lgtm thank you! https://codereview.chromium.org/2823923002/diff/1/chrome/browser/extensions/u... File chrome/browser/extensions/updater/extension_updater_unittest.cc (right): https://codereview.chromium.org/2823923002/diff/1/chrome/browser/extensions/u... chrome/browser/extensions/updater/extension_updater_unittest.cc:884: std::string expected_updater_value = base::StringPrintf( this can be const.
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2823923002/diff/1/chrome/browser/extensions/u... File chrome/browser/extensions/updater/extension_updater_unittest.cc (right): https://codereview.chromium.org/2823923002/diff/1/chrome/browser/extensions/u... chrome/browser/extensions/updater/extension_updater_unittest.cc:884: std::string expected_updater_value = base::StringPrintf( On 2017/04/19 16:02:20, Sorin Jianu wrote: > this can be const. Done.
The CQ bit was checked by rdevlin.cronin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sorin@chromium.org, mxnguyen@chromium.org Link to the patchset: https://codereview.chromium.org/2823923002/#ps20001 (title: "const-ify")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492624768124210,
"parent_rev": "d132421d7a007dacb588ca4b098f38759a5a5481", "commit_rev":
"70dab6f4ff7ddadd4b1da803bfb0baf93a8f0512"}
Message was sent while issue was closed.
Description was changed from ========== [Extensions] Only add traffic management headers for webstore updates Instead of adding traffic management headers for all update pings, only include them for pings sent to the webstore. BUG=647516 ========== to ========== [Extensions] Only add traffic management headers for webstore updates Instead of adding traffic management headers for all update pings, only include them for pings sent to the webstore. BUG=647516 Review-Url: https://codereview.chromium.org/2823923002 Cr-Commit-Position: refs/heads/master@{#465668} Committed: https://chromium.googlesource.com/chromium/src/+/70dab6f4ff7ddadd4b1da803bfb0... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/70dab6f4ff7ddadd4b1da803bfb0... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
