Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: extensions/browser/updater/extension_downloader.cc

Issue 2823923002: [Extensions] Only add traffic management headers for webstore updates (Closed)
Patch Set: const-ify Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/updater/extension_updater_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/updater/extension_downloader.cc
diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/browser/updater/extension_downloader.cc
index b3e084a91df53c2d02b9e7cb33432db4083de457..1798285151dbf040a65cf2398a5473d9540eca9f 100644
--- a/extensions/browser/updater/extension_downloader.cc
+++ b/extensions/browser/updater/extension_downloader.cc
@@ -489,18 +489,20 @@ void ExtensionDownloader::CreateManifestFetcher() {
net::LOAD_DO_NOT_SAVE_COOKIES |
net::LOAD_DISABLE_CACHE);
- // Send traffic-management headers.
+ // Send traffic-management headers to the webstore.
// https://bugs.chromium.org/p/chromium/issues/detail?id=647516
- manifest_fetcher_->AddExtraRequestHeader(base::StringPrintf(
- "%s: %s", kUpdateInteractivityHeader,
- active_request->foreground_check() ? kUpdateInteractivityForeground
- : kUpdateInteractivityBackground));
- manifest_fetcher_->AddExtraRequestHeader(
- base::StringPrintf("%s: %s", kUpdateAppIdHeader, id_list.c_str()));
- manifest_fetcher_->AddExtraRequestHeader(base::StringPrintf(
- "%s: %s-%s", kUpdateUpdaterHeader,
- UpdateQueryParams::GetProdIdString(UpdateQueryParams::CRX),
- UpdateQueryParams::GetProdVersion().c_str()));
+ if (extension_urls::IsWebstoreUpdateUrl(active_request->full_url())) {
+ manifest_fetcher_->AddExtraRequestHeader(base::StringPrintf(
+ "%s: %s", kUpdateInteractivityHeader,
+ active_request->foreground_check() ? kUpdateInteractivityForeground
+ : kUpdateInteractivityBackground));
+ manifest_fetcher_->AddExtraRequestHeader(
+ base::StringPrintf("%s: %s", kUpdateAppIdHeader, id_list.c_str()));
+ manifest_fetcher_->AddExtraRequestHeader(base::StringPrintf(
+ "%s: %s-%s", kUpdateUpdaterHeader,
+ UpdateQueryParams::GetProdIdString(UpdateQueryParams::CRX),
+ UpdateQueryParams::GetProdVersion().c_str()));
+ }
// Update checks can be interrupted if a network change is detected; this is
// common for the retail mode AppPack on ChromeOS. Retrying once should be
« no previous file with comments | « chrome/browser/extensions/updater/extension_updater_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698