Extracts parameters to WindowTreeHostMus into structure

Extracts parameters to WindowTreeHostMus into structure

I'm going to need to pass additional parameters to the
constructor. It's getting a bit unwieldy and having two constructors
for two different purposes is error prone. So, I've extracted the
paramters into a structure and created a factory function for the
common case.

BUG=708287
TEST=covered by tests
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2823903005
Cr-Commit-Position: refs/heads/master@{#465685}
Committed: https://chromium.googlesource.com/chromium/src/+/a5a9fddc48214cb8114e39fe1659e130a178cc3a

[sky, 2017-04-19 03:21:26]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 03:21:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 04:33:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 04:33:44]

Dry run: This issue passed the CQ dry run.

[Elliot Glaysher, 2017-04-19 17:17:33]

https://codereview.chromium.org/2823903005/diff/20001/ui/aura/mus/window_tree...
File ui/aura/mus/window_tree_host_mus_init_params.h (right):

https://codereview.chromium.org/2823903005/diff/20001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_host_mus_init_params.h:46: AURA_EXPORT
std::unique_ptr<WindowTreeHostMusInitParams>
Is there a reason you're using a unique_ptr instead of making
WindowTreeHostMusInitParams movable? You don't appear to be doing any subtyping
of the struct.

[sky, 2017-04-19 17:52:26]

Good idea. Done.

[sky, 2017-04-19 17:52:29]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 17:52:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-04-19 17:58:25]

lgtm

[sky, 2017-04-19 18:00:37]

The CQ bit was unchecked by sky@chromium.org

[sky, 2017-04-19 18:00:41]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-04-19 18:00:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 18:59:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492624841739240,
"parent_rev": "28cc7e40db7981ddcea21485ca17de6df59aa8a9", "commit_rev":
"a5a9fddc48214cb8114e39fe1659e130a178cc3a"}

[commit-bot: I haz the power, 2017-04-19 19:00:09]

Description was changed from

==========
Extracts parameters to WindowTreeHostMus into structure

I'm going to need to pass additional parameters to the
constructor. It's getting a bit unwieldy and having two constructors
for two different purposes is error prone. So, I've extracted the
paramters into a structure and created a factory function for the
common case.

BUG=708287
TEST=covered by tests
R=erg@chromium.org
==========

to

==========
Extracts parameters to WindowTreeHostMus into structure

I'm going to need to pass additional parameters to the
constructor. It's getting a bit unwieldy and having two constructors
for two different purposes is error prone. So, I've extracted the
paramters into a structure and created a factory function for the
common case.

BUG=708287
TEST=covered by tests
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2823903005
Cr-Commit-Position: refs/heads/master@{#465685}
Committed:
https://chromium.googlesource.com/chromium/src/+/a5a9fddc48214cb8114e39fe1659...
==========

[commit-bot: I haz the power, 2017-04-19 19:00:11]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a5a9fddc48214cb8114e39fe1659...