Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2823863002: views: don't make device chooser's client view huge (Closed)

Created:
3 years, 8 months ago by Elly Fong-Jones
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

views: don't make device chooser's client view huge ChooserDialogView's client view does not need to be 402x320, since the DeviceChooserContentView sizes itself. Worse, explicitly sizing the ChooserDialogView's client view causes the dialog to double in height. BUG=706337 Review-Url: https://codereview.chromium.org/2804303002 Cr-Commit-Position: refs/heads/master@{#463225} (cherry picked from commit 48fd59f0ef21b6daffc42147ac15bff3aefd4e67) Review-Url: https://codereview.chromium.org/2823863002 . Cr-Commit-Position: refs/branch-heads/3029@{#730} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/064f15c744cccb39236945565edf9e2977251940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M chrome/browser/ui/views/extensions/chooser_dialog_view.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Elly Fong-Jones
3 years, 8 months ago (2017-04-17 14:35:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
064f15c744cccb39236945565edf9e2977251940.

Powered by Google App Engine
This is Rietveld 408576698