Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2804303002: views: don't make device chooser's client view huge (Closed)

Created:
3 years, 8 months ago by Elly Fong-Jones
Modified:
3 years, 8 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

views: don't make device chooser's client view huge ChooserDialogView's client view does not need to be 402x320, since the DeviceChooserContentView sizes itself. Worse, explicitly sizing the ChooserDialogView's client view causes the dialog to double in height. BUG=706337 Review-Url: https://codereview.chromium.org/2804303002 Cr-Commit-Position: refs/heads/master@{#463225} Committed: https://chromium.googlesource.com/chromium/src/+/48fd59f0ef21b6daffc42147ac15bff3aefd4e67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M chrome/browser/ui/views/extensions/chooser_dialog_view.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Elly Fong-Jones
benwells: ptal? :)
3 years, 8 months ago (2017-04-07 17:01:46 UTC) #3
benwells
lgtm
3 years, 8 months ago (2017-04-10 05:47:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804303002/1
3 years, 8 months ago (2017-04-10 11:12:35 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 11:56:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/48fd59f0ef21b6daffc42147ac15...

Powered by Google App Engine
This is Rietveld 408576698