Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2823603002:
Stop checking for crash strings in PaintController death tests (Closed)
|
Created:
3 years, 8 months ago by chrishtr Modified:
3 years, 8 months ago Reviewers:
Nico CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionStop checking for messages in PaintController death tests
These strings don't exist in official builds, which makes the test fail.
Furthermore, they don't add much value.
BUG=710470
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2823603002
Cr-Commit-Position: refs/heads/master@{#464744}
Committed: https://chromium.googlesource.com/chromium/src/+/c288893814fc243404bf5280fb71afe79bc18ace
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
Description was changed from ========== none BUG= ========== to ========== none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
Description was changed from ========== none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Stop checking for messages in PaintController death tests These strings don't exist in official builds, which makes the test fail. Furthermore, they don't add much value. BUG=710470 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
chrishtr@chromium.org changed reviewers: + thakis@chromium.org
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm to get bots green, but do the death tests themselves add much value?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by chrishtr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/04/14 at 15:41:27, thakis wrote: > lgtm to get bots green, but do the death tests themselves add much value? They do add value. The particular under-invalidation code this is testing discover important and otherwise hard-to-find bugs in paint invalidation. I also refactored some of the code in the past week, and these tests helped me catch at least 2 or 3 bugs in my implementation.
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492190124321570, "parent_rev":
"446bcc3d1881a89471235aff30d25c38b2b3547f", "commit_rev":
"c288893814fc243404bf5280fb71afe79bc18ace"}
Message was sent while issue was closed.
Description was changed from ========== Stop checking for messages in PaintController death tests These strings don't exist in official builds, which makes the test fail. Furthermore, they don't add much value. BUG=710470 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Stop checking for messages in PaintController death tests These strings don't exist in official builds, which makes the test fail. Furthermore, they don't add much value. BUG=710470 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2823603002 Cr-Commit-Position: refs/heads/master@{#464744} Committed: https://chromium.googlesource.com/chromium/src/+/c288893814fc243404bf5280fb71... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c288893814fc243404bf5280fb71...
Message was sent while issue was closed.
Cool, thanks for confirming. On Apr 14, 2017 1:16 PM, <chrishtr@chromium.org> wrote: On 2017/04/14 at 15:41:27, thakis wrote: > lgtm to get bots green, but do the death tests themselves add much value? They do add value. The particular under-invalidation code this is testing discover important and otherwise hard-to-find bugs in paint invalidation. I also refactored some of the code in the past week, and these tests helped me catch at least 2 or 3 bugs in my implementation. https://codereview.chromium.org/2823603002/ -- You received this message because you are subscribed to the Google Groups "Blink Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
Cool, thanks for confirming. On Apr 14, 2017 1:16 PM, <chrishtr@chromium.org> wrote: On 2017/04/14 at 15:41:27, thakis wrote: > lgtm to get bots green, but do the death tests themselves add much value? They do add value. The particular under-invalidation code this is testing discover important and otherwise hard-to-find bugs in paint invalidation. I also refactored some of the code in the past week, and these tests helped me catch at least 2 or 3 bugs in my implementation. https://codereview.chromium.org/2823603002/ -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
