Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1372)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp

Issue 2823603002: Stop checking for crash strings in PaintController death tests (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp b/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
index 038f0bd39cacaf61f7e07130d344487e70fa0ee9..5a09e2d8edd67cbbfd1cc59229bf53a681efe1bc 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
@@ -2276,7 +2276,7 @@ class PaintControllerUnderInvalidationTest
};
TEST_F(PaintControllerUnderInvalidationTest, ChangeDrawing) {
- EXPECT_DEATH(TestChangeDrawing(), "under-invalidation: display item changed");
+ EXPECT_DEATH(TestChangeDrawing(), "");
}
TEST_F(PaintControllerUnderInvalidationTest, MoreDrawing) {
@@ -2297,29 +2297,22 @@ TEST_F(PaintControllerUnderInvalidationTest, NoopPairsInSubsequence) {
}
TEST_F(PaintControllerUnderInvalidationTest, ChangeDrawingInSubsequence) {
- EXPECT_DEATH(TestChangeDrawingInSubsequence(),
- "\"\\(In cached subsequence of first\\)\" under-invalidation: "
- "display item changed");
+ EXPECT_DEATH(TestChangeDrawingInSubsequence(), "");
}
TEST_F(PaintControllerUnderInvalidationTest, MoreDrawingInSubsequence) {
- EXPECT_DEATH(TestMoreDrawingInSubsequence(),
- "Check failed: false. Can't find cached display item");
+ EXPECT_DEATH(TestMoreDrawingInSubsequence(), "");
}
TEST_F(PaintControllerUnderInvalidationTest, LessDrawingInSubsequence) {
// We allow invalidated display item clients as long as they would produce the
// same display items. The cases of changed display items are tested by other
// test cases.
- EXPECT_DEATH(TestLessDrawingInSubsequence(),
- "\"\\(In cached subsequence of first\\)\" under-invalidation: "
- "new subsequence wrong length");
+ EXPECT_DEATH(TestLessDrawingInSubsequence(), "");
}
TEST_F(PaintControllerUnderInvalidationTest, ChangeNonCacheableInSubsequence) {
- EXPECT_DEATH(TestChangeNonCacheableInSubsequence(),
- "\"\\(In cached subsequence of container\\)\" "
- "under-invalidation: display item changed");
+ EXPECT_DEATH(TestChangeNonCacheableInSubsequence(), "");
}
TEST_F(PaintControllerUnderInvalidationTest, InvalidationInSubsequence) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698