Remove ScriptState::GetFromExtrasExports

Remove ScriptState::GetFromExtrasExports

ScriptState::GetFromExtrasExports is only used once (in V8ScriptRunner::CallExtraHelper). This CL inlines the function in order to remove an unneeded depenency to ScriptValue in ScriptState.

BUG=682322
Review-Url: https://codereview.chromium.org/2823473002
Cr-Commit-Position: refs/heads/master@{#465332}
Committed: https://chromium.googlesource.com/chromium/src/+/17e20ad4e87b628b0434747f5733fc7bf5108822

[adithyas, 2017-04-13 20:47:03]

The CQ bit was checked by adithyas@chromium.org to run a CQ dry run

[adithyas, 2017-04-13 20:47:11]

adithyas@chromium.org changed reviewers:
+ jbroman@chromium.org

[commit-bot: I haz the power, 2017-04-13 20:47:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-04-13 22:55:43]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2017-04-13 22:55:44]

LGTM

https://codereview.chromium.org/2823473002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp (right):

https://codereview.chromium.org/2823473002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp:738:
v8::Local<v8::Value> undefined = v8::Undefined(isolate);

Nit: This variable looks redundant.

[commit-bot: I haz the power, 2017-04-14 00:38:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 00:38:34]

Dry run: This issue passed the CQ dry run.

[adithyas, 2017-04-18 15:28:13]

https://codereview.chromium.org/2823473002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp (right):

https://codereview.chromium.org/2823473002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp:738:
v8::Local<v8::Value> undefined = v8::Undefined(isolate);
On 2017/04/13 at 22:55:44, haraken wrote:
> Nit: This variable looks redundant.

Yup, removed.

[jbroman, 2017-04-18 15:29:24]

lgtm

[adithyas, 2017-04-18 15:32:09]

The CQ bit was checked by adithyas@chromium.org

[adithyas, 2017-04-18 15:32:09]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2823473002/#ps20001
(title: "Rebase, remove unused var")

[commit-bot: I haz the power, 2017-04-18 15:32:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 19:43:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492529529445490,
"parent_rev": "8e209a99612f0af2a91c940967eacef653fa20b1", "commit_rev":
"17e20ad4e87b628b0434747f5733fc7bf5108822"}

[commit-bot: I haz the power, 2017-04-18 19:43:38]

Description was changed from

==========
Remove ScriptState::GetFromExtrasExports

ScriptState::GetFromExtrasExports is only used once (in
V8ScriptRunner::CallExtraHelper). This CL inlines the function in order to
remove an unneeded depenency to ScriptValue in ScriptState.

BUG=682322
==========

to

==========
Remove ScriptState::GetFromExtrasExports

ScriptState::GetFromExtrasExports is only used once (in
V8ScriptRunner::CallExtraHelper). This CL inlines the function in order to
remove an unneeded depenency to ScriptValue in ScriptState.

BUG=682322

Review-Url: https://codereview.chromium.org/2823473002
Cr-Commit-Position: refs/heads/master@{#465332}
Committed:
https://chromium.googlesource.com/chromium/src/+/17e20ad4e87b628b0434747f5733...
==========

[commit-bot: I haz the power, 2017-04-18 19:43:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/17e20ad4e87b628b0434747f5733...