Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2823473002: Remove ScriptState::GetFromExtrasExports (Closed)

Created:
3 years, 8 months ago by adithyas
Modified:
3 years, 8 months ago
Reviewers:
haraken, jbroman
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScriptState::GetFromExtrasExports ScriptState::GetFromExtrasExports is only used once (in V8ScriptRunner::CallExtraHelper). This CL inlines the function in order to remove an unneeded depenency to ScriptValue in ScriptState. BUG=682322 Review-Url: https://codereview.chromium.org/2823473002 Cr-Commit-Position: refs/heads/master@{#465332} Committed: https://chromium.googlesource.com/chromium/src/+/17e20ad4e87b628b0434747f5733fc7bf5108822

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase, remove unused var #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -25 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptState.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp View 1 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h View 1 chunk +2 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
adithyas
3 years, 8 months ago (2017-04-13 20:47:11 UTC) #3
haraken
LGTM https://codereview.chromium.org/2823473002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp File third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp (right): https://codereview.chromium.org/2823473002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp#newcode738 third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp:738: v8::Local<v8::Value> undefined = v8::Undefined(isolate); Nit: This variable looks ...
3 years, 8 months ago (2017-04-13 22:55:44 UTC) #6
adithyas
https://codereview.chromium.org/2823473002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp File third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp (right): https://codereview.chromium.org/2823473002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp#newcode738 third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp:738: v8::Local<v8::Value> undefined = v8::Undefined(isolate); On 2017/04/13 at 22:55:44, haraken ...
3 years, 8 months ago (2017-04-18 15:28:13 UTC) #9
jbroman
lgtm
3 years, 8 months ago (2017-04-18 15:29:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823473002/20001
3 years, 8 months ago (2017-04-18 15:32:50 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 19:43:39 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/17e20ad4e87b628b0434747f5733...

Powered by Google App Engine
This is Rietveld 408576698