Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h

Issue 2823473002: Remove ScriptState::GetFromExtrasExports (Closed)
Patch Set: Rebase, remove unused var Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
index 8cfb3906c31b2da383512d0634bc77cc24f3cb16..4629a20e109e0d45f29049d6eb887225dc72c575 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
@@ -143,20 +143,10 @@ class CORE_EXPORT V8ScriptRunner final {
const v8::ScriptOrigin&);
private:
- static v8::MaybeLocal<v8::Value> CallExtraHelper(ScriptState* script_state,
+ static v8::MaybeLocal<v8::Value> CallExtraHelper(ScriptState*,
const char* name,
size_t num_args,
- v8::Local<v8::Value>* args) {
- v8::Isolate* isolate = script_state->GetIsolate();
- v8::Local<v8::Value> undefined = v8::Undefined(isolate);
- v8::Local<v8::Value> function_value =
- script_state->GetFromExtrasExports(name).V8Value();
- if (function_value.IsEmpty())
- return v8::MaybeLocal<v8::Value>();
- v8::Local<v8::Function> function = function_value.As<v8::Function>();
- return V8ScriptRunner::CallInternalFunction(function, undefined, num_args,
- args, isolate);
- }
+ v8::Local<v8::Value>* args);
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698