Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2823343002:
Add a POSIX version of FileUtilTest.SetNonBlocking. (Closed)
DescriptionAdd a POSIX version of FileUtilTest.SetNonBlocking.
Review-Url: https://codereview.chromium.org/2823343002
Cr-Commit-Position: refs/heads/master@{#465397}
Committed: https://chromium.googlesource.com/chromium/src/+/755180d8641630a1141fc9a272839b8dee1352a0
Patch Set 1 #Patch Set 2 : Just add the test, fix Android, fix bad upload #
Total comments: 2
Messages
Total messages: 24 (17 generated)
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Patchset #2 (id:20001) has been deleted
Description was changed from ========== Add a POSIX version of FileUtilTest.SetNonBlocking. Use shortened FPL macro everywhere to reduce line wrapping. ========== to ========== Add a POSIX version of FileUtilTest.SetNonBlocking. ==========
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
thestig@chromium.org changed reviewers: + tfarina@chromium.org
Nice! Thanks for adding this test Lei. I should have done this before. LGTM. https://codereview.chromium.org/2823343002/diff/40001/base/files/file_util_un... File base/files/file_util_unittest.cc (right): https://codereview.chromium.org/2823343002/diff/40001/base/files/file_util_un... base/files/file_util_unittest.cc:2265: ScopedFD fd(open(path.value().c_str(), O_RDONLY)); Could we also test with socket() or for our test it is just the same as opening a file?
https://codereview.chromium.org/2823343002/diff/40001/base/files/file_util_un... File base/files/file_util_unittest.cc (right): https://codereview.chromium.org/2823343002/diff/40001/base/files/file_util_un... base/files/file_util_unittest.cc:2265: ScopedFD fd(open(path.value().c_str(), O_RDONLY)); On 2017/04/18 22:14:42, tfarina wrote: > Could we also test with socket() or for our test it is just the same as opening > a file? I wasn't really aiming for this to be a comprehensive test. Just cover some basic functionality. Feel free to build on top of this if you are interested.
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492553969622440,
"parent_rev": "a38716a1806d8b03999d77f9bbfb1e793f60f34b", "commit_rev":
"755180d8641630a1141fc9a272839b8dee1352a0"}
Message was sent while issue was closed.
Description was changed from ========== Add a POSIX version of FileUtilTest.SetNonBlocking. ========== to ========== Add a POSIX version of FileUtilTest.SetNonBlocking. Review-Url: https://codereview.chromium.org/2823343002 Cr-Commit-Position: refs/heads/master@{#465397} Committed: https://chromium.googlesource.com/chromium/src/+/755180d8641630a1141fc9a27283... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/755180d8641630a1141fc9a27283... |
