Add a POSIX version of FileUtilTest.SetNonBlocking.

base/files/file_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
 #include <fstream>
 #include <initializer_list>
@@ skipping 2237 matching lines @@
 
   FilePath foo(empty_dir.Append(FILE_PATH_LITERAL("foo.txt")));
   std::string bar("baz");
   ASSERT_EQ(static_cast<int>(bar.length()),
             WriteFile(foo, bar.c_str(), bar.length()));
 
   EXPECT_FALSE(IsDirectoryEmpty(empty_dir));
 }
 
 #if defined(OS_POSIX)
+TEST_F(FileUtilTest, SetNonBlocking) {
+  const int kInvalidFd = 99999;
+  EXPECT_FALSE(SetNonBlocking(kInvalidFd));
+
+  base::FilePath path;
+  ASSERT_TRUE(PathService::Get(base::DIR_TEST_DATA, &path));
+  path = path.Append(FPL("file_util")).Append(FPL("original.txt"));
+  ScopedFD fd(open(path.value().c_str(), O_RDONLY));

[tfarina, 2017/04/18 22:14:42]

Could we also test with socket() or for our test it is just the same as opening
a file?

[Lei Zhang, 2017/04/18 22:19:11]

I wasn't really aiming for this to be a comprehensive test. Just cover some
basic functionality. Feel free to build on top of this if you are interested.

+  ASSERT_GE(fd.get(), 0);
+  EXPECT_TRUE(SetNonBlocking(fd.get()));
+}
 
 // Testing VerifyPathControlledByAdmin() is hard, because there is no
 // way a test can make a file owned by root, or change file paths
 // at the root of the file system.  VerifyPathControlledByAdmin()
 // is implemented as a call to VerifyPathControlledByUser, which gives
 // us the ability to test with paths under the test's temp directory,
 // using a user id we control.
 // Pull tests of VerifyPathControlledByUserTest() into a separate test class
 // with a common SetUp() method.
 class VerifyPathControlledByUserTest : public FileUtilTest {
@@ skipping 350 matching lines @@
   // Trying to close it should crash. This is important for security.
   EXPECT_DEATH(CloseWithScopedFD(fds[1]), "");
 #endif
 }
 
 #endif  // defined(OS_POSIX)
 
 }  // namespace
 
 }  // namespace base